Skip to content

outposts: fix patch processing#6338

Merged
BeryJu merged 3 commits intogoauthentik:mainfrom
ChandonPierre:cpierre/jsonpatch
Jul 24, 2023
Merged

outposts: fix patch processing#6338
BeryJu merged 3 commits intogoauthentik:mainfrom
ChandonPierre:cpierre/jsonpatch

Conversation

@ChandonPierre
Copy link
Contributor

@ChandonPierre ChandonPierre commented Jul 23, 2023

Details

Changes

New Features

  • Fixes reconcile error 'PrometheusServiceMonitor' object has no attribute 'openapi_types'
  • Fixes patches.get() always returning None

Breaking Changes

  • N/A

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@ChandonPierre ChandonPierre requested a review from a team as a code owner July 23, 2023 15:16
@ChandonPierre ChandonPierre requested review from rissson and removed request for a team July 23, 2023 15:16
@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit dd26f49
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64be4a702b4fd80008e6c31f

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.35 ⚠️

Comparison is base (d435a65) 92.50% compared to head (dd26f49) 92.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6338      +/-   ##
==========================================
- Coverage   92.50%   92.14%   -0.35%     
==========================================
  Files         560      560              
  Lines       26993    27002       +9     
==========================================
- Hits        24967    24879      -88     
- Misses       2026     2123      +97     
Flag Coverage Δ
e2e 50.75% <13.34%> (-0.96%) ⬇️
integration 26.54% <60.00%> (+0.01%) ⬆️
unit 89.27% <13.34%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/outposts/controllers/k8s/base.py 81.82% <60.00%> (-1.92%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu enabled auto-merge (squash) July 24, 2023 09:55
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit dd26f49
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64be4a70f112870008fdabff
😎 Deploy Preview https://deploy-preview-6338--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu merged commit 8d4b7ce into goauthentik:main Jul 24, 2023
kensternberg-authentik added a commit that referenced this pull request Jul 24, 2023
* main:
  web/admin: hide pagination when no data is loaded yet (#6353)
  web/admin: adjust style of page header (#6355)
  root: set csrf cookie's secure flag same as session (#6350)
  outposts: Fix infinite self-recursion in traefik reconciler. (#6336)
  outposts: fix patch processing (#6338)
  web: bump API Client version (#6351)
  Updates for file web/xliff/en.xlf in zh_CN on branch main (#6340)
  Updates for file web/xliff/en.xlf in zh-Hans on branch main (#6341)
  enterprise: fix license check not using DER as spec specifies (#6348)
  core: bump goauthentik.io/api/v3 from 3.2023061.3 to 3.2023061.4 (#6342)
  core: bump drf-spectacular from 0.26.3 to 0.26.4 (#6343)
  core: bump ruff from 0.0.278 to 0.0.280 (#6344)
  website: bump postcss from 8.4.26 to 8.4.27 in /website (#6345)
  web: bump @esbuild/linux-arm64 from 0.18.15 to 0.18.16 in /web (#6347)
  web: bump @esbuild/darwin-arm64 from 0.18.15 to 0.18.16 in /web (#6346)
  outposts: support json patch for Kubernetes (#6319)
  providers/oauth2: fix grant_type password raising an exception (#6333)
  web: bump API Client version (#6331)
  enterprise: cleanup v2 (#6330)
  web: bump prettier from 2.8.8 to 3.0.0 in /web (#6329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants