Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6121 +/- ##
==========================================
- Coverage 92.49% 92.47% -0.01%
==========================================
Files 561 561
Lines 27075 27075
==========================================
- Hits 25039 25034 -5
- Misses 2036 2041 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Do we want to automatically push those changes on the PR branch? |
rissson
commented
Jul 3, 2023
| on: | ||
| pull_request: | ||
| branches: | ||
| - main |
Member
Author
There was a problem hiding this comment.
Suggested change
| - main | |
| - main | |
| paths: | |
| - "**/*.jpg" | |
| - "**/*.png" |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-compress-images-1690977763-6429764
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-compress-images-1690977763-6429764-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-compress-images-1690977763-6429764For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-compress-images-1690977763-6429764-arm64Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
reviewed
Jul 4, 2023
Member
BeryJu
left a comment
There was a problem hiding this comment.
I don't think we'll get much of a size improvement from the image compression (at least from the potential pain of making a CI pipeline for that), I'm curious of how much of a difference ignoring .git makes with docker
Member
Author
The size reduction by compressing images is 72M, which makes our docker image go from 832M to 760M, i.e. a 9% improvement.
We can also not make a CI pipeline and just have this as a one-off.
Nothing in terms of image size now that I looked at it more closely, as we don't do |
Member
Author
e916078 to
138333a
Compare
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
138333a to
893c280
Compare
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 53.7%, saving 13.32 MB.
12 images did not require optimisation. |
Member
Author
|
Unfortunately, I cannot customize the commit message :/ |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
approved these changes
Aug 2, 2023
Member
BeryJu
left a comment
There was a problem hiding this comment.
LGTM, commit message doesn't really matter since we squash merge anyways
I copied all the current state icons/etc to https://github.com/goauthentik/brand-assets to keep the original copies (not that it matters too much since we have svgs but anyways)
rissson
commented
Aug 2, 2023
Signed-off-by: risson <18313093+rissson@users.noreply.github.com>
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 7, 2023
* main: (36 commits) website/blog: add github user name links (#6468) website/developer-docs: add new template for procedures (#6390) website/blogs: blog to celebrate hackathon (#6457) web/flows: add more stories (#6444) web: bump prettier from 3.0.0 to 3.0.1 in /web (#6465) core: bump debugpy from 1.6.7 to 1.6.8 (#6458) ci: bump peter-evans/create-pull-request from 4 to 5 (#6459) web: bump lit from 2.7.6 to 2.8.0 in /web (#6460) web: bump @fortawesome/fontawesome-free from 6.4.0 to 6.4.2 in /web (#6461) web: bump chart.js from 4.3.2 to 4.3.3 in /web (#6462) web: bump @lit-labs/task from 2.1.2 to 3.0.0 in /web (#6463) web, website: compress images (#6121) core: bump cryptography from 41.0.2 to 41.0.3 (#6456) root: replace builtin psycopg libpq binary implementation with distro… (#6448) website: fix broken links in NewsBar core: bump github.com/getsentry/sentry-go from 0.22.0 to 0.23.0 (#6449) core: bump goauthentik.io/api/v3 from 3.2023061.6 to 3.2023061.7 (#6450) web: bump pyright from 1.1.319 to 1.1.320 in /web (#6451) core: bump ruff from 0.0.281 to 0.0.282 (#6453) core: bump golang from 1.20.6-bullseye to 1.20.7-bullseye (#6454) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Compress images. This should be lossless. Size gain: 88M -> 16M.
Somewhat part of https://github.com/goauthentik/meta/issues/20, as I'll also be excluding the
.gitfolder from the docker build.Changes
New Features
Breaking Changes
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)