web/flows: fix RedirectStage not detecting absolute URLs correctly#5781
Merged
BeryJu merged 2 commits intogoauthentik:mainfrom May 29, 2023
Saeverix:patch-1
Merged
web/flows: fix RedirectStage not detecting absolute URLs correctly#5781BeryJu merged 2 commits intogoauthentik:mainfrom Saeverix:patch-1
BeryJu merged 2 commits intogoauthentik:mainfrom
Saeverix:patch-1
Conversation
…5732) Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com>
|
After I built my own Authentik image with the changes that @Saeverix made, I can confirm that all my OAuth connections are working properly. I am using:
Everything is working perfectly! |
Contributor
Author
|
@Smallinger thanks for checking my changes and confirming that it works. |
Member
|
I've simplified the code a bit to use the native JS URL APIs and tested it with Portainer locally |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
===========================================
- Coverage 92.63% 26.42% -66.21%
===========================================
Files 547 547
Lines 26250 26250
===========================================
- Hits 24314 6933 -17381
- Misses 1936 19317 +17381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@BeryJu that's also a nice change to prevent the |
BeryJu
approved these changes
May 29, 2023
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kensternberg-authentik
added a commit
that referenced
this pull request
May 30, 2023
* main: (58 commits) web: bump @babel/preset-env from 7.22.2 to 7.22.4 in /web (#5808) web: bump @typescript-eslint/eslint-plugin from 5.59.7 to 5.59.8 in /web (#5805) web: bump @babel/plugin-transform-runtime from 7.22.2 to 7.22.4 in /web (#5806) web: bump @typescript-eslint/parser from 5.59.7 to 5.59.8 in /web (#5807) stages/deny: fix typos (#5800) core: bump coverage from 7.2.6 to 7.2.7 (#5809) blueprints: allow setting user's passwords from blueprints (#5797) providers/proxy: add support for traefik.io API and CRD (#5801) web: fix build (#5798) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781) lifecycle: Add depends_on for worker and server container (#5634) web: bump @babel/preset-env from 7.21.5 to 7.22.2 in /web (#5791) web: bump @babel/plugin-proposal-decorators from 7.21.0 to 7.22.3 in /web (#5787) web: bump @lingui/core from 4.1.2 to 4.2.0 in /web (#5782) website: bump postcss from 8.4.23 to 8.4.24 in /website (#5783) web: bump @babel/plugin-transform-runtime from 7.21.4 to 7.22.2 in /web (#5789) core: bump goauthentik.io/api/v3 from 3.2023051.3 to 3.2023052.1 (#5788) web: bump @babel/core from 7.21.8 to 7.22.1 in /web (#5790) web: bump yaml from 2.3.0 to 2.3.1 in /web (#5792) core: bump django-otp from 1.2.0 to 1.2.1 (#5794) ...
BeryJu
added a commit
that referenced
this pull request
May 31, 2023
…5781) * web: getURL() method in RedirectStage.ts now actually detects URLs (#5732) Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com> * use native API to build full URL Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Saeverix <1863379+Saeverix@users.noreply.github.com> Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 1, 2023
* main: web: bump API Client version (#5826) release: 2023.5.3 website/docs: prepare 2023.5.3 (#5824) ci: build outpost binaries statically linked (#5823) blueprints: fix API validation with OCI blueprint path (#5822) ci: replace github bot account with github app (#5819) providers/ldap: fix LDAP Outpost application selection (#5812) stages/deny: fix typos (#5800) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 5, 2023
* main: web: bump API Client version (#5826) release: 2023.5.3 website/docs: prepare 2023.5.3 (#5824) ci: build outpost binaries statically linked (#5823) blueprints: fix API validation with OCI blueprint path (#5822) ci: replace github bot account with github app (#5819) providers/ldap: fix LDAP Outpost application selection (#5812) stages/deny: fix typos (#5800) web/flows: fix RedirectStage not detecting absolute URLs correctly (#5781)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Resolves Portianer OAuth is broken after update. #5732
Changes
New Features
getURL()method inRedirectStage.tsnow actually detects URLsChecklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)