web/user: fix broken search on application library#5743
Merged
kensternberg-authentik merged 1 commit intomainfrom May 24, 2023
Merged
web/user: fix broken search on application library#5743kensternberg-authentik merged 1 commit intomainfrom
kensternberg-authentik merged 1 commit intomainfrom
Conversation
This is *mortifying*. I didn't test this well enough, and apparently
broke it again once I'd tested it. This patch restores the original
behavior ("no match" means "just show everything"), and fixes a
small bit of semantic lint -- the "search" feature should not be
assigning meaning to what it finds; it's enough to pass back the
prioritized list to whatever client wanted it, and let the client
decide what to do with it.
|
|
||
| renderSearch() { | ||
| return html`<ak-library-list-search .apps="{this.apps.results}"></ak-library-list-search>`; | ||
| return html`<ak-library-list-search .apps=${this.apps.results}></ak-library-list-search>`; |
Contributor
Author
There was a problem hiding this comment.
This was the real issue; everything else is just dealing with errors to the console when the field is cleared (when there is no app[0]). I got this to work, then moved it here and effed-up my argument call. Massive apologies.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5743 +/- ##
==========================================
- Coverage 92.65% 92.64% -0.00%
==========================================
Files 547 547
Lines 26227 26242 +15
==========================================
+ Hits 24298 24310 +12
- Misses 1929 1932 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-library-search-1684943529-dfd40e0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-library-search-1684943529-dfd40e0-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-library-search-1684943529-dfd40e0For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-library-search-1684943529-dfd40e0-arm64Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
approved these changes
May 24, 2023
ChandonPierre
pushed a commit
to ChandonPierre/authentik
that referenced
this pull request
Jun 1, 2023
web: fix broken search on application library
This is *mortifying*. I didn't test this well enough, and apparently
broke it again once I'd tested it. This patch restores the original
behavior ("no match" means "just show everything"), and fixes a
small bit of semantic lint -- the "search" feature should not be
assigning meaning to what it finds; it's enough to pass back the
prioritized list to whatever client wanted it, and let the client
decide what to do with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mortifying. I didn't test this well enough, and apparently broke it again once I'd tested it. This patch restores the original behavior ("no match" means "just show everything"), and fixes a small bit of semantic lint -- the "search" feature should not be assigning meaning to what it finds; it's enough to pass back the prioritized list to whatever client wanted it, and let the client decide what to do with it.
Details
Resolves #5171
Changes
Fixes the search feature so that the data being passed back and forth correspond to the design.
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)