root: Improve Redis configuration#5395
Closed
PKizzle wants to merge 211 commits intogoauthentik:mainfrom
Closed
Conversation
Use URL in order to configure redis instead of multiple configuration options. Switch to go-redis v9.
…feature/add-redis-sentinel-support # Conflicts: # go.mod # go.sum # poetry.lock
…feature/add-redis-sentinel-support
…feature/add-redis-sentinel-support # Conflicts: # lifecycle/wait_for_db.py # poetry.lock
Add link to license for provided source code
Allow to specify most Redis configuration options using a single URL. For Kombu provide separate configuration options as it requires a different URL format.
…feature/add-redis-sentinel-support # Conflicts: # go.sum # lifecycle/wait_for_db.py
…feature/add-redis-sentinel-support # Conflicts: # go.sum
…feature/add-redis-sentinel-support # Conflicts: # Dockerfile
…feature/add-redis-sentinel-support
…feature/add-redis-sentinel-support
…feature/add-redis-sentinel-support
Usage of socket_timeout clashes with BRPOP
…feature/add-redis-sentinel-support # Conflicts: # internal/config/struct.go
Add the required urls.py file
# Conflicts: # go.sum
pylint-django is not yet compatible with version 3.x
# Conflicts: # go.sum
Contributor
Author
|
There are no tests for the added middleware as more discussion is needed whether Redis sentinel and unix socket configurations shall be tested e2e using the GitHub actions. |
# Conflicts: # authentik/root/test_runner.py # lifecycle/system_migrations/to_0_13_authentik.py
# Conflicts: # lifecycle/system_migrations/to_0_13_authentik.py
PKizzle
added a commit
to PKizzle/authentik
that referenced
this pull request
Oct 8, 2023
This is handled in goauthentik#5395
# Conflicts: # authentik/lib/config.py # lifecycle/system_migrations/to_0_13_authentik.py
# Conflicts: # go.sum
|
@PKizzle Any reason to close this PR? Are we still looking at using Redis Cluster? |
Contributor
Author
|
@gcarrarom I renamed the branch to better organise them locally and GitHub did not like that. The PR still lives on as #7118. It also includes Redis Cluster support. Please test it thoroughly and report any bugs. |
BeryJu
added a commit
that referenced
this pull request
Nov 10, 2023
) * Initial commit * Remove any remaining mentions of Redis URL This is handled in #5395 * Allow setting broker transport options This enables usage of other brokers that require additional settings * Remove remaining reference to Redis URL This functionality is not part of this PR * Reset default TLS requirements to none * Fix linter errors * Move dict from base64 encoded json to config.py Additionally add tests * Replace ast.literal_eval with json.loads * Use default channel and cache backend configuration If more customization is desired users shall look at goauthentik.io/docs/installation/configuration#custom-python-settings * Send config deprecation notification to all superusers * Remove duplicate method * Add configuration explanation For channel layer settings * Use Event for deprecation warning * Fix remove duplicated method * Add missing comma * Update authentik/lib/config.py Signed-off-by: Jens L. <jens@beryju.org> * Fix Event deprecation handling --------- Signed-off-by: Jens L. <jens@beryju.org> Co-authored-by: Jens L <jens@beryju.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Resolves #5077, resolves #1285
Changes
New Features
Breaking Changes
Several new Redis configuration env vars are no longer supported as everything is handled using the URLAdditional information
Todo
Dockerfile adjustments,env variable deprecation logic and Redis URL parsing -> does not make sense