web/flow: reset stale authenticator selection between consecutive validate stages#20802
Merged
GirlBossRush merged 5 commits intogoauthentik:mainfrom Mar 19, 2026
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20802 +/- ##
==========================================
- Coverage 93.49% 93.44% -0.05%
==========================================
Files 993 993
Lines 56146 56146
==========================================
- Hits 52491 52468 -23
- Misses 3655 3678 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d3b5189 to
6782464
Compare
web/src/flow/stages/authenticator_validate/AuthenticatorValidateStage.ts
Show resolved
Hide resolved
web/src/flow/stages/authenticator_validate/AuthenticatorValidateStage.ts
Show resolved
Hide resolved
web/src/flow/stages/authenticator_validate/AuthenticatorValidateStage.ts
Show resolved
Hide resolved
Fix lint and typing for authenticator component resolver Format authenticator resolver signature chore: trigger CI rerun after transient npm network failure
fbb4cb9 to
3975722
Compare
GirlBossRush
approved these changes
Mar 19, 2026
Contributor
|
@Oluwatobi-Mustapha Thank you sending such a detailed PR! 🥂 The changes here look great and align with an ongoing effort to make the flow stages easier to test and reason about. I can merge this now and the changes should appear in the next release, as well as our next patch release of 2026.2 |
Contributor
|
|
kensternberg-authentik
added a commit
that referenced
this pull request
Mar 24, 2026
* main: web: link file picker to docs (#20995) web/flow: reset stale authenticator selection between consecutive validate stages (#20802) ci: bump actions/cache from 5.0.3 to 5.0.4 (#21002) root: init rust workspace (#20983) website/docs: fix swapped sidebar label (#21011) core: bump goauthentik/fips-python from `ec5c4cd` to `859ad57` in /lifecycle/container (#21003) core: bump goauthentik/fips-debian from `a613b75` to `7baeeaa` in /lifecycle/container (#21001) core: bump djangorestframework from 3.16.1 to 3.17.0 (#21000) lifecycle/aws: bump aws-cdk from 2.1111.0 to 2.1112.0 in /lifecycle/aws (#20999) ci: bump codecov/codecov-action from 5.5.2 to 5.5.3 in /.github/actions/test-results (#21004) web: bump the storybook group across 1 directory with 5 updates (#21005) web: bump knip from 5.87.0 to 5.88.0 in /web (#21006) web: bump @formatjs/intl-listformat from 8.2.3 to 8.3.1 in /web (#21007) website/docs: update kubernetes install guide for Gateway API (#20961)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14941
When the authenticator-validate stage component is reused across consecutive MFA stages, the previous selected challenge can persist into the next stage even if that challenge is no longer allowed.
This change resets the selected challenge when
challengeupdates and the previous selection is not present in the newdeviceChallengesset, then re-runs the existing auto-selection initialization path for the new challenge.Also adds unit coverage for stale-selection reset behavior.