Skip to content

enterprise/wsfed: Fix metadata export and signing logic#20643

Merged
PeshekDotDev merged 2 commits intomainfrom
wsfed-metadata-error
Mar 2, 2026
Merged

enterprise/wsfed: Fix metadata export and signing logic#20643
PeshekDotDev merged 2 commits intomainfrom
wsfed-metadata-error

Conversation

@PeshekDotDev
Copy link
Contributor

@PeshekDotDev PeshekDotDev commented Mar 1, 2026

Details

REPLACE ME

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@PeshekDotDev PeshekDotDev requested a review from a team as a code owner March 1, 2026 09:04
@PeshekDotDev PeshekDotDev self-assigned this Mar 1, 2026
@netlify
Copy link

netlify bot commented Mar 1, 2026

✅ Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit ffe2612
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69a401144b9ff400088f8bee
😎 Deploy Preview https://deploy-preview-20643--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 1, 2026

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit ffe2612
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69a40114aaf6e6000835774c
😎 Deploy Preview https://deploy-preview-20643--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PeshekDotDev
Copy link
Contributor Author

PeshekDotDev commented Mar 1, 2026

@BeryJu I believe it's possible for the sign in/acs url to be something like company.com/signin and the logout url to be company.com/signout, so we may need to update the url validation logic for that. Or add a form input for the logout url

@codecov
Copy link

codecov bot commented Mar 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (f875d5e) to head (ffe2612).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20643      +/-   ##
==========================================
- Coverage   93.38%   93.34%   -0.05%     
==========================================
  Files         981      981              
  Lines       55387    55392       +5     
==========================================
- Hits        51724    51703      -21     
- Misses       3663     3689      +26
Flag Coverage Δ
conformance 37.69% <20.00%> (+<0.01%) ⬆️
e2e 43.33% <100.00%> (+0.03%) ⬆️
integration 22.42% <0.00%> (-0.04%) ⬇️
unit 91.53% <100.00%> (-0.01%) ⬇️
unit-migrate 91.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ffe2612d9e7933f7ead223d3adde544f89880b65
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ffe2612d9e7933f7ead223d3adde544f89880b65

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu changed the title enterprise/wsfed: Fix metadata import and signing logic enterprise/wsfed: Fix metadata export and signing logic Mar 1, 2026
@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Mar 1, 2026
@BeryJu BeryJu added the backport/version-2026.2 Add this label to PRs to backport changes to version-2026.2 label Mar 1, 2026
@PeshekDotDev PeshekDotDev merged commit 7dd36ea into main Mar 2, 2026
104 checks passed
@PeshekDotDev PeshekDotDev deleted the wsfed-metadata-error branch March 2, 2026 02:15
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Mar 2, 2026
authentik-automation bot pushed a commit that referenced this pull request Mar 2, 2026
@PeshekDotDev @authentik-automation
enterprise/wsfed: Fix metadata export and signing logic (#20643)
f4cc570
@authentik-automation authentik-automation bot mentioned this pull request Mar 2, 2026
Merged
@authentik-automation
Copy link
Contributor

authentik-automation bot commented Mar 2, 2026

🍒 Cherry-pick to version-2026.2 created: #20649

gergosimonyi pushed a commit that referenced this pull request Mar 2, 2026
@authentik-automation @PeshekDotDev
enterprise/wsfed: Fix metadata export and signing logic (cherry-pick #…
ef1aad5 
…20643 to version-2026.2) (#20649)

enterprise/wsfed: Fix metadata export and signing logic (#20643)

Co-authored-by: Connor Peshek <connor@connorpeshek.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeryJu BeryJu BeryJu approved these changes

Assignees

@PeshekDotDev PeshekDotDev

Labels

backport/version-2026.2 Add this label to PRs to backport changes to version-2026.2

Projects

authentik Core
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeshekDotDev @BeryJu