core: recursion to get deepest child#20325
Merged
dominic-r merged 1 commit intosdko/provider-type-fix-ldapfrom Feb 16, 2026
Merged
core: recursion to get deepest child#20325dominic-r merged 1 commit intosdko/provider-type-fix-ldapfrom
dominic-r merged 1 commit intosdko/provider-type-fix-ldapfrom
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dominic-r
approved these changes
Feb 16, 2026
BeryJu
reviewed
Feb 16, 2026
Comment on lines
+33
to
+37
| try: | ||
| child = getattr(parent, submodel) | ||
| break | ||
| except AttributeError: | ||
| continue |
Member
There was a problem hiding this comment.
should be a hasattr probably, this isn't directly in the hotpath but could be quite likely involved in it and throwing exceptions just for that is wasteful
Collaborator
Author
There was a problem hiding this comment.
I wager we'll save about a microsecond per execution with
Suggested change
| try: | |
| child = getattr(parent, submodel) | |
| break | |
| except AttributeError: | |
| continue | |
| if hasattr(parent, submodel): | |
| child = parent.submodel | |
| break |
:)
dominic-r
pushed a commit
that referenced
this pull request
Feb 27, 2026
add recursive approach to get deepest child object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dominic-r