outpost/proxyv2: prevent panic in handleSignOut#20097
Merged
gergosimonyi merged 1 commit intogoauthentik:mainfrom Mar 3, 2026
Merged
outpost/proxyv2: prevent panic in handleSignOut#20097gergosimonyi merged 1 commit intogoauthentik:mainfrom
gergosimonyi merged 1 commit intogoauthentik:mainfrom
Conversation
…nt panic Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20097 +/- ##
==========================================
- Coverage 93.23% 93.19% -0.05%
==========================================
Files 968 968
Lines 53589 53589
==========================================
- Hits 49965 49941 -24
- Misses 3624 3648 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gergosimonyi
approved these changes
Mar 3, 2026
authentik-automation bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
outpost/proxyv2: use safe claims extraction in handleSignOut to prevent panic Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
Contributor
|
🍒 Cherry-pick to |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fix a panic that occurs when accessing
/outpost.goauthentik.io/sign_outon proxy outposts using the new PostgreSQL session backend due to an unsafe type assertion.The fix replaces the manual session reading with a call to the existing
getClaimsFromSessionmethod, which already handles the PostgreSQL store safely via a checked type assertion.Fixes #17922
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)