web: Allow unused spreaded properties to strict unsafe.#20084
web: Allow unused spreaded properties to strict unsafe.#20084GirlBossRush merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20084 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 968 968
Lines 53580 53580
=======================================
+ Hits 49964 49966 +2
+ Misses 3616 3614 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-12044e86c814eac92adc010159afeec4d9de6ee8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-12044e86c814eac92adc010159afeec4d9de6ee8Afterwards, run the upgrade commands from the latest release notes. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Details
This PR fixes a runtime error that occurs on the sources wizard:
The issue stems from
StrictUnsafethrowing an error on components which do not implement themodelNameproperty. This was initially to catch errors, but given our common pattern of spreading attributes and properties over a union of elements, it may be more ergonomic to allow this JSX-like behavior.