Skip to content

web: Allow unused spreaded properties to strict unsafe.#20084

Merged
GirlBossRush merged 2 commits intomainfrom
fix-strict-unsafe-properties
Feb 6, 2026
Merged

web: Allow unused spreaded properties to strict unsafe.#20084
GirlBossRush merged 2 commits intomainfrom
fix-strict-unsafe-properties

Conversation

@GirlBossRush
Copy link
Contributor

Details

This PR fixes a runtime error that occurs on the sources wizard:

return html`
    <ak-wizard-page-form
        slot=${`type-${type.component}-${type.modelName}`}
        label=${msg(str`Create ${type.name}`)}
    >
        ${StrictUnsafe<CustomFormElementTagName>(type.component, {
            modelName: type.modelName,
        })}
    </ak-wizard-page-form>
`;

The issue stems from StrictUnsafe throwing an error on components which do not implement the modelName property. This was initially to catch errors, but given our common pattern of spreading attributes and properties over a union of elements, it may be more ergonomic to allow this JSX-like behavior.

@GirlBossRush GirlBossRush self-assigned this Feb 6, 2026
@GirlBossRush GirlBossRush requested a review from a team as a code owner February 6, 2026 06:59
@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Feb 6, 2026
@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 12044e8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69860c76236ccc0008928143
😎 Deploy Preview https://deploy-preview-20084--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 5578f3b
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6985914a5ea49c0008c00aeb
😎 Deploy Preview https://deploy-preview-20084--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (032da33) to head (12044e8).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20084   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         968      968           
  Lines       53580    53580           
=======================================
+ Hits        49964    49966    +2     
+ Misses       3616     3614    -2     
Flag Coverage Δ
conformance 37.95% <ø> (+<0.01%) ⬆️
e2e 43.94% <ø> (ø)
integration 22.71% <ø> (+<0.01%) ⬆️
unit 91.42% <ø> (+0.01%) ⬆️
unit-migrate 91.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-12044e86c814eac92adc010159afeec4d9de6ee8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-12044e86c814eac92adc010159afeec4d9de6ee8

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush enabled auto-merge (squash) February 6, 2026 15:13
@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Feb 6, 2026
@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 12044e8
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/69860c76f652b40008845b45
😎 Deploy Preview https://deploy-preview-20084--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GirlBossRush GirlBossRush merged commit 0dab651 into main Feb 6, 2026
101 checks passed
@GirlBossRush GirlBossRush deleted the fix-strict-unsafe-properties branch February 6, 2026 16:09
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Feb 6, 2026
atereshkin pushed a commit to atereshkin/authentik that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants