Skip to content

stages/authenticator_webauthn: fix double JSON encoding of webauthn options#19952

Merged
BeryJu merged 1 commit intomainfrom
stages/authenticator_webauthn/fix-double-jsoning
Feb 3, 2026
Merged

stages/authenticator_webauthn: fix double JSON encoding of webauthn options#19952
BeryJu merged 1 commit intomainfrom
stages/authenticator_webauthn/fix-double-jsoning

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 2, 2026

some housekeeping

there used to not be an option exposed for just putting this data in a format that is JSON-serializable so our next closest thing was to just serialize it to json then load it again to include it in our API

…ptions

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 2, 2026 23:49
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 176dde5
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/698137fa6835290008b7a587
😎 Deploy Preview https://deploy-preview-19952--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (aaad609) to head (176dde5).
⚠️ Report is 21 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19952      +/-   ##
==========================================
- Coverage   93.27%   93.20%   -0.07%     
==========================================
  Files         968      968              
  Lines       53332    53330       -2     
==========================================
- Hits        49746    49707      -39     
- Misses       3586     3623      +37     
Flag Coverage Δ
conformance 38.07% <50.00%> (-0.01%) ⬇️
e2e 44.07% <100.00%> (-0.01%) ⬇️
integration 22.87% <50.00%> (-0.06%) ⬇️
unit 91.41% <100.00%> (+<0.01%) ⬆️
unit-migrate 91.44% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-176dde5997cfc3e385e0a4e3262dcc7c19a9da27
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-176dde5997cfc3e385e0a4e3262dcc7c19a9da27

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 095ff25 into main Feb 3, 2026
102 checks passed
@BeryJu BeryJu deleted the stages/authenticator_webauthn/fix-double-jsoning branch February 3, 2026 20:59
kensternberg-authentik added a commit that referenced this pull request Feb 4, 2026
* main: (26 commits)
  providers/saml: auto pull signature algorithm options (#17614)
  core, web: bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /packages/prettier-config (#19990)
  web: bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /web (#19989)
  stages/authenticator_webauthn: fix double JSON encoding of webauthn options (#19952)
  core: bump django from 5.2.10 to 5.2.11 (#19988)
  ci: allow setting assignee to fail (#19985)
  root: revert enterprise loading behaviour (#19485)
  web/flows: update flow background (#19974)
  providers/oauth2: use compare_digest for client_secret comparison (#19979)
  recovery: consume token in transaction (#19967)
  core: ask for token duration on recovery link/email by admin (#19875)
  core: bump aws-cdk-lib from 2.236.0 to 2.237.0 (#19958)
  web: bump the storybook group across 1 directory with 5 updates (#19960)
  core: bump library/nginx from `c881927` to `7fe5dda` in /website (#19961)
  core: bump gunicorn from 25.0.0 to 25.0.1 (#19959)
  core: bump goauthentik.io/api/v3 to 3.2026.2.0-rc1-1770129730 (#19973)
  lifecycle: bump shm size (#19369)
  crypto: Add ED25519 and ED448 support to the certificate builder (#19465)
  web/admin: Register stage elements. Fix linter warnings (#19948)
  web: bump knip from 5.82.1 to 5.83.0 in /web (#19962)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant