core: fix non-expiring service accounts and app passwords (cherry-pick #19913 to version-2025.12)#19941
Merged
melizeche merged 1 commit intoversion-2025.12from Feb 2, 2026
Conversation
core: fix datetime (de)?serialization We aim to fix #19911 in the next patch release, so this commit shouldn't include an API change, which is why we do it a bit awkwardly. Additionally, `serializeForm` has no typechecking for its return value (`return json as unknown as T`), and should be refactored for type safety if at all possible. There are at least two bugs we're solving in this commit: 1. Type checking fails on `serializeForm`, which results in `expires: null` POSTed in a `UserServiceAccountRequest`, where it is not allowed. The backend "correctly" returns a 400. For now we address this by returning `undefined` from `serializeForm` on a `datetime-local` input element when it is unset. 2. The schema allows for `expires: null` in `TokenModel`, but fails with a 500 when that is actually sent. For now we address this with a `None` check. (Note: this bug will not be encountered by the frontend after the change from `null` to `undefined`, but it's still nice to fix.) Both of these issues should eventually be solved by the backend handling `ExpiringModel` in an `ExpiringModelSerializer` instead of the current ad hoc way. Introduced by #19561 Co-authored-by: Simonyi Gergő <gergo@goauthentik.io>
melizeche
approved these changes
Feb 2, 2026
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
enchantednatures
pushed a commit
to enchantednatures/HomeCluster
that referenced
this pull request
Feb 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [authentik](https://registry.terraform.io/providers/goauthentik/authentik) ([source](https://redirect.github.com/goauthentik/terraform-provider-authentik)) | required_provider | patch | `2025.12.0` → `2025.12.1` | | [authentik](https://goauthentik.io) ([source](https://redirect.github.com/goauthentik/helm)) | | patch | `2025.12.2` → `2025.12.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>goauthentik/terraform-provider-authentik (authentik)</summary> ### [`v2025.12.1`](https://redirect.github.com/goauthentik/terraform-provider-authentik/releases/tag/v2025.12.1) [Compare Source](https://redirect.github.com/goauthentik/terraform-provider-authentik/compare/v2025.12.0...v2025.12.1) ##### Changelog - [`a19acb4`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/a19acb417fb54a542a6476bda37775684ae8574a): fix int conversion for outpost provider attachment ([#​832](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/832)) ([@​BeryJu](https://redirect.github.com/BeryJu)) - [`a923cda`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/a923cda4bf2f0ec295be296dcbbebe8f7ada11d1): fix: Support path-based Authentik deployments in URL configuration ([#​829](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/829)) ([@​StefanMarkmann](https://redirect.github.com/StefanMarkmann)) - [`8edeec9`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/8edeec9805f126d1deb1ad5aa1a50740c5aaadfd): Bump github.com/getsentry/sentry-go from 0.40.0 to 0.41.0 ([#​834](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/834)) ([@​dependabot](https://redirect.github.com/dependabot)\[bot]) - [`e10b039`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/e10b039884fb2fbe8ff34a6557dc38d4e714ae96): Bump actions/checkout from 6.0.1 to 6.0.2 ([#​836](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/836)) ([@​dependabot](https://redirect.github.com/dependabot)\[bot]) - [`aa73b84`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/aa73b84a5653eeb68633f9334cf7836d9112bbbc): Bump github.com/getsentry/sentry-go from 0.41.0 to 0.42.0 ([#​842](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/842)) ([@​dependabot](https://redirect.github.com/dependabot)\[bot]) - [`4553f1d`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/4553f1dba852ed64819277f3426aaf1cf449c25e): Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.38.1 to 2.38.2 ([#​844](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/844)) ([@​dependabot](https://redirect.github.com/dependabot)\[bot]) - [`749d807`](https://redirect.github.com/goauthentik/terraform-provider-authentik/commit/749d807758f8d4f5a0dd2f5b4a52ad54827ac28b): fix: paginate RbacPermissionsList to find all role permissions ([#​841](https://redirect.github.com/goauthentik/terraform-provider-authentik/issues/841)) ([@​dominic-r](https://redirect.github.com/dominic-r)) </details> <details> <summary>goauthentik/helm (authentik)</summary> ### [`v2025.12.3`](https://redirect.github.com/goauthentik/helm/releases/tag/authentik-2025.12.3) [Compare Source](https://redirect.github.com/goauthentik/helm/compare/authentik-2025.12.2...authentik-2025.12.3) authentik is an open-source Identity Provider focused on flexibility and versatility #### What's Changed - charts/authentik: bump to 2025.12.3 by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [#​444](https://redirect.github.com/goauthentik/helm/pull/444) - 2025.12: Revert bulk revoke added by accident in release branch by [@​dominic-r](https://redirect.github.com/dominic-r) in [goauthentik/authentik#19870](https://redirect.github.com/goauthentik/authentik/pull/19870) - web/admin: fix toggle-group for bindings now showing up (cherry-pick [#​19820](https://redirect.github.com/goauthentik/helm/issues/19820) to version-2025.12) by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [goauthentik/authentik#19895](https://redirect.github.com/goauthentik/authentik/pull/19895) - web: fix Brand CSS not applied to nested Shadow DOM components (cherry-pick [#​19892](https://redirect.github.com/goauthentik/helm/issues/19892) to version-2025.12) by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [goauthentik/authentik#19900](https://redirect.github.com/goauthentik/authentik/pull/19900) - ci: always generate API clients ([#​19906](https://redirect.github.com/goauthentik/helm/issues/19906)) by [@​BeryJu](https://redirect.github.com/BeryJu) in [goauthentik/authentik#19932](https://redirect.github.com/goauthentik/authentik/pull/19932) - lifecycle/ak: make sure /data has the correct permissions (cherry-pick [#​19935](https://redirect.github.com/goauthentik/helm/issues/19935) to version-2025.12) by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [goauthentik/authentik#19940](https://redirect.github.com/goauthentik/authentik/pull/19940) - lifecycle/aws: add /data volume (cherry-pick [#​19936](https://redirect.github.com/goauthentik/helm/issues/19936) to version-2025.12) by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [goauthentik/authentik#19938](https://redirect.github.com/goauthentik/authentik/pull/19938) - core: fix non-expiring service accounts and app passwords (cherry-pick [#​19913](https://redirect.github.com/goauthentik/helm/issues/19913) to version-2025.12) by [@​authentik-automation](https://redirect.github.com/authentik-automation)\[bot] in [goauthentik/authentik#19941](https://redirect.github.com/goauthentik/authentik/pull/19941) **Full Changelog**: <goauthentik/authentik@version/2025.12.2...version/2025.12.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/enchantednatures/HomeCluster). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45NS4yIiwidXBkYXRlZEluVmVyIjoiNDIuOTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #19913 to
version-2025.12branch.Original PR: #19913
Original Author: @dominic-r
Cherry-picked commit: 12ebd3b