Skip to content

admin/files: add centralized theme variable support for file URLs (cherry-pick #19657 to version-2025.12)#19793

Merged
dominic-r merged 2 commits intoversion-2025.12from
cherry-pick/19657-to-version-2025.12
Jan 30, 2026
Merged

admin/files: add centralized theme variable support for file URLs (cherry-pick #19657 to version-2025.12)#19793
dominic-r merged 2 commits intoversion-2025.12from
cherry-pick/19657-to-version-2025.12

Conversation

@authentik-automation
Copy link
Contributor

⚠️ This cherry-pick has conflicts that require manual resolution.

Cherry-pick of #19657 to version-2025.12 branch.

Original PR: #19657
Original Author: @dominic-r
Cherry-picked commit: 33594c9

Please resolve the conflicts in this PR before merging.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit b589289
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/697bf4c0b27b40000787fedc
😎 Deploy Preview https://deploy-preview-19793--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 98.52941% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (a4187ba) to head (b589289).
⚠️ Report is 1 commits behind head on version-2025.12.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/models.py 81.81% 2 Missing ⚠️
authentik/admin/files/manager.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           version-2025.12   #19793      +/-   ##
===================================================
- Coverage            92.95%   92.46%   -0.49%     
===================================================
  Files                  947      947              
  Lines                52369    52545     +176     
===================================================
- Hits                 48678    48586      -92     
- Misses                3691     3959     +268     
Flag Coverage Δ
e2e 43.30% <25.98%> (-0.07%) ⬇️
integration ?
unit 91.57% <98.52%> (+0.02%) ⬆️
unit-migrate 91.61% <98.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r dominic-r enabled auto-merge (squash) January 29, 2026 21:40
@dominic-r dominic-r force-pushed the cherry-pick/19657-to-version-2025.12 branch from 57c3629 to 23a6654 Compare January 29, 2026 21:40
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b589289faa74521f74fd179813be727b30f1b340
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b589289faa74521f74fd179813be727b30f1b340

Afterwards, run the upgrade commands from the latest release notes.

dominic-r and others added 2 commits January 29, 2026 19:01
This cherry-pick has conflicts that need manual resolution.

Original PR: #19657
Original commit: 33594c9
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@dominic-r dominic-r force-pushed the cherry-pick/19657-to-version-2025.12 branch from 23a6654 to b589289 Compare January 30, 2026 00:01
@dominic-r dominic-r disabled auto-merge January 30, 2026 00:58
@dominic-r dominic-r enabled auto-merge (squash) January 30, 2026 00:58
@dominic-r dominic-r merged commit 15c4de7 into version-2025.12 Jan 30, 2026
123 of 125 checks passed
@dominic-r dominic-r deleted the cherry-pick/19657-to-version-2025.12 branch January 30, 2026 01:10
tacerus added a commit to tacerus/authentik that referenced this pull request Feb 11, 2026
In
15c4de7 ("admin/files: add centralized theme variable support for file URLs (cherry-pick goauthentik#19657 to version-2025.12) (goauthentik#19793)")
the frontend side replacement was removed in favor of handling the
replacement in the media backend. Unfortunately, this does not seem to
work in our setup, as the logo URL containing "%(theme)s" started to
be served without any replacement after the update. This might be a bug,
but needs more investigation and, if needed, an upstream report. Until
then, as a temporary hotfix, restore the frontend/JS based replacement.

Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants