web/admin: fix impersonation form requesting data without being opened#19673
Merged
web/admin: fix impersonation form requesting data without being opened#19673
Conversation
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19673 +/- ##
==========================================
- Coverage 93.27% 93.22% -0.06%
==========================================
Files 949 949
Lines 52131 52131
==========================================
- Hits 48626 48599 -27
- Misses 3505 3532 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-dfdd214bba12b851b62150b69d3b9439eab5cc28
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-dfdd214bba12b851b62150b69d3b9439eab5cc28Afterwards, run the upgrade commands from the latest release notes. |
Contributor
|
|
authentik-automation bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
#19673) * reverse bubble events Signed-off-by: Jens Langhammer <jens@goauthentik.io> * rework impersonation form to not use firstUpdated Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Contributor
|
🍒 Cherry-pick to |
BeryJu
added a commit
that referenced
this pull request
Jan 23, 2026
…d (cherry-pick #19673 to version-2025.10) (#19711) * Cherry-pick #19673 to version-2025.10 (with conflicts) This cherry-pick has conflicts that need manual resolution. Original PR: #19673 Original commit: 0a10b81 * fix conflict Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L. <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Jan 23, 2026
…d (cherry-pick #19673 to version-2025.12) (#19712) web/admin: fix impersonation form requesting data without being opened (#19673) * reverse bubble events * rework impersonation form to not use firstUpdated --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L. <jens@goauthentik.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired #19671
currently when opening a list of 20 users, the impersonation form will make 20 identical requests to the system settings endpoint to know if the reason is required.
this PR fixes the behaviour to only fetch that data when the modal is opened.
@goauthentik/frontend will probably hate me for the change of reverse-bubbling the events down to the modal children, but I can't think of a better way to handle this
ref https://github.com/goauthentik/internal-customer-ref/issues/2