Skip to content

endpoints/connectors/agent: Skip Endpoint stage on device IA & fix confusing identification subtext#19482

Merged
BeryJu merged 3 commits intomainfrom
endpoints/connectors/agent/fix-stage-device-ia
Jan 15, 2026
Merged

endpoints/connectors/agent: Skip Endpoint stage on device IA & fix confusing identification subtext#19482
BeryJu merged 3 commits intomainfrom
endpoints/connectors/agent/fix-stage-device-ia

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 15, 2026

  • when doing device interactive auth, let the endpoint stage continue as we already know the device based on the DTH header
  • only show "continuing to device xyz" when using device IA flow, not when using an endpoint stage only

…s we already know the device based on the DTH header

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
…hen using an endpoint stage with browser extension

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner January 15, 2026 13:23
@BeryJu BeryJu added area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 labels Jan 15, 2026
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 67459d6
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6968ea5a39875600083c149f
😎 Deploy Preview https://deploy-preview-19482--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.19%. Comparing base (244962d) to head (725d760).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/endpoints/connectors/agent/stage.py 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19482      +/-   ##
==========================================
+ Coverage   92.54%   93.19%   +0.64%     
==========================================
  Files         949      949              
  Lines       52015    52030      +15     
==========================================
+ Hits        48136    48488     +352     
+ Misses       3879     3542     -337     
Flag Coverage Δ
conformance 38.29% <38.88%> (-0.01%) ⬇️
e2e 43.15% <55.55%> (-1.09%) ⬇️
integration 23.21% <33.33%> (?)
unit 91.49% <55.55%> (-0.02%) ⬇️
unit-migrate 91.48% <55.55%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 41c24c6 into main Jan 15, 2026
140 of 143 checks passed
@BeryJu BeryJu deleted the endpoints/connectors/agent/fix-stage-device-ia branch January 15, 2026 15:53
authentik-automation bot pushed a commit that referenced this pull request Jan 15, 2026
…nfusing identification subtext (#19482)

* when doing device interactive auth, let the endpoint stage continue as we already know the device based on the DTH header

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* only show "continuing to device xyz" when using device IA flow, not when using an endpoint stage with browser extension

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* format

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.12 created: #19486

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-725d76095abf3ac84a742bcab0d86a0c34d2c84c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-725d76095abf3ac84a742bcab0d86a0c34d2c84c

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added a commit that referenced this pull request Jan 15, 2026
…nfusing identification subtext (cherry-pick #19482 to version-2025.12) (#19486)

endpoints/connectors/agent: Skip Endpoint stage on device IA & fix confusing identification subtext (#19482)

* when doing device interactive auth, let the endpoint stage continue as we already know the device based on the DTH header



* only show "continuing to device xyz" when using device IA flow, not when using an endpoint stage with browser extension



* format



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 31, 2026
* main: (47 commits)
  endpoints/connectors/agent: add tests for IA endpoint stage (#19487)
  website/docs: limiting permissions of AD service account (#19483)
  endpoints/connectors/agent: Skip Endpoint stage on device IA & fix confusing identification subtext (#19482)
  root: adjust makefile for non-brew macos (#19479)
  providers/oauth2: allow property mappings to override scope claim in access tokens (#19226)
  revert: lib: use orjson for structlog json (#19478)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#19464)
  core: bump library/nginx from `e3a22a7` to `c881927` in /website (#19469)
  core: bump library/node from 25.2.1-trixie to 25.3.0-trixie in /website (#19468)
  web: bump prettier from 3.7.4 to 3.8.0 in /web (#19471)
  website/integrations: add MinIO AIStor configuration via environment variables (#19337)
  root: upgrade ruff lint for 3.14 (#19461)
  lib: use orjson for structlog json (#19462)
  ci: fix checkout stable (for 2025.12) (#19448)
  root: Python 3.14 (#17313)
  core: bump channels from 4.3.1 to 4.3.2 (#19458)
  core: bump mypy from 1.18.2 to 1.19.1 (#19457)
  core: bump google-api-python-client from 2.177.0 to 2.188.0 (#19443)
  core: bump selenium from 4.32.0 to 4.39.0 (#19455)
  core: bump msgraph-sdk from 1.39.0 to 1.52.0 (#19454)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant