Address review feedback on FleetDM connector implementation#18651
Merged
GirlBossRush merged 4 commits intoendpoints/fleet-connectorfrom Dec 8, 2025
Merged
Address review feedback on FleetDM connector implementation#18651GirlBossRush merged 4 commits intoendpoints/fleet-connectorfrom
GirlBossRush merged 4 commits intoendpoints/fleet-connectorfrom
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-integrations canceled.
|
Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on FleetDM connector PR
Add public override modifiers to updated method in FleetConnectorViewPage
Dec 6, 2025
Contributor
|
@copilot This is a nice small improvement but please include some more of the suggested changes in #18589 |
Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com>
Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com>
Contributor
Author
I've addressed all 8 review suggestions from #18589 in commits d16dcbc and 4a33e99: FleetConnectorForm.ts:
FleetConnectorViewPage.ts:
|
Copilot
AI
changed the title
Add public override modifiers to updated method in FleetConnectorViewPage
Address review feedback on FleetDM connector implementation
Dec 6, 2025
BeryJu
added a commit
that referenced
this pull request
Jan 23, 2026
* enterprise/endpoints/connectors/fleet: init Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # blueprints/schema.json # schema.yml * add ui Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix desc Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add configurable headers Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add tests Signed-off-by: Jens Langhammer <jens@goauthentik.io> * Address review feedback on FleetDM connector implementation (#18651) * Initial plan * Add public override modifiers to updated method Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com> * Address additional feedback from PR #18589 Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com> * Fix indentation in ak-switch-input component Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com> * fix permission model Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add attributes to device access group Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add option to map device team Signed-off-by: Jens Langhammer <jens@goauthentik.io> * cleanup Signed-off-by: Jens Langhammer <jens@goauthentik.io> * update schema Signed-off-by: Jens Langhammer <jens@goauthentik.io> * format Signed-off-by: Jens Langhammer <jens@goauthentik.io> * switch connector to grid, add icons Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix pagination Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add software tab Signed-off-by: Jens Langhammer <jens@goauthentik.io> * fix pages in test Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add more test devices Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add fedora test machine Signed-off-by: Jens Langhammer <jens@goauthentik.io> * better formatting for OS version Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: GirlBossRush <592134+GirlBossRush@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Addresses multiple review suggestions from #18589 to improve code quality, consistency, and maintainability across the FleetDM connector implementation.
Changes to FleetConnectorForm.ts:
public overridemodifier togetSuccessMessage()method for proper method override declarationifDefined()directive with nullish coalescing operator (??) for cleaner, more idiomatic TypeScriptak-switch-inputcomponent for consistency with codebase patternsifDefinedimportChanges to FleetConnectorViewPage.ts:
public overridemodifier toupdated()lifecycle method for consistency withwillUpdate()methodPFBaseimport and from styles array (already provided byAKElementbase class)protectedaccess modifier torenderTabOverview()methodModelEnumsplit operation to module-level constant for better performance and reusabilityThese changes align with established patterns throughout the web codebase (e.g.,
SearchSelect.ts,HorizontalFormElement.ts) and address all 8 review comments from the original PR.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.