Skip to content

web: Codemirror fixes#18610

Merged
GirlBossRush merged 13 commits intomainfrom
codemirror-dynamic
Dec 4, 2025
Merged

web: Codemirror fixes#18610
GirlBossRush merged 13 commits intomainfrom
codemirror-dynamic

Conversation

@GirlBossRush
Copy link
Contributor

Details

This PR fixes several issues with Codemirror after the latest dependencies upgrade.

Fixes

  • Load Codemirror dynamically, fixing page stutters before Codemirror is rendered
  • Clean up error reporting on user provided input
  • Fix ARIA attributes which prevented tabbing into the editor element

@GirlBossRush GirlBossRush requested a review from a team as a code owner December 4, 2025 16:28
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 2fab053
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6931d65669b63000089787cd
😎 Deploy Preview https://deploy-preview-18610--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 2fab053
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6931d656b4a0af00088eab3d

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 2fab053
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6931d656da05e00008dfb5ad

@GirlBossRush GirlBossRush self-assigned this Dec 4, 2025
@GirlBossRush GirlBossRush added a11y Features or issues related to accessibility area:frontend Features or issues related to the browser, TypeScript, Node.js, etc labels Dec 4, 2025
@GirlBossRush GirlBossRush added this to the Release 2025.12 milestone Dec 4, 2025
@GirlBossRush GirlBossRush changed the title Codemirror dynamic web: Codemirror fixes Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (6d5092a) to head (2fab053).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18610      +/-   ##
==========================================
+ Coverage   93.01%   93.23%   +0.22%     
==========================================
  Files         932      933       +1     
  Lines       51095    51157      +62     
==========================================
+ Hits        47527    47698     +171     
+ Misses       3568     3459     -109     
Flag Coverage Δ
e2e 44.75% <ø> (+1.02%) ⬆️
integration 22.77% <ø> (-0.03%) ⬇️
unit 91.45% <ø> (+<0.01%) ⬆️
unit-migrate 91.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and nicely organized. Small suggestion to restrict our codeset via Pick<> and let Typescript and ts-pattern do the magic, but it's not necessary.

GirlBossRush and others added 3 commits December 4, 2025 18:04
Co-authored-by: Ken Sternberg <133134217+kensternberg-authentik@users.noreply.github.com>
Signed-off-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-2fab053371495b6e54f635258e5ac1740c2ab342
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-2fab053371495b6e54f635258e5ac1740c2ab342

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush enabled auto-merge (squash) December 4, 2025 19:15
@GirlBossRush GirlBossRush merged commit 05c30af into main Dec 4, 2025
97 checks passed
@GirlBossRush GirlBossRush deleted the codemirror-dynamic branch December 4, 2025 19:15
kensternberg-authentik added a commit that referenced this pull request Dec 11, 2025
* main: (40 commits)
  enterprise/stages/mtls: fix traefik certificate parsing (#18607)
  wed/admin: change s to S in "Stage" (#18632)
  flows: refresh unauthenticated tabs (#18621)
  flows: keep ?next url when using cancel (#18619)
  core, web: update translations (#18620)
  ci: bump actions/setup-node from 6.0.0 to 6.1.0 (#18552)
  core: bump goauthentik/fips-debian from `cf233be` to `a80dbbd` (#18594)
  web: bump @sentry/browser from 10.28.0 to 10.29.0 in /web in the sentry group across 1 directory (#18623)
  website/docs: adds note about ak_create_jwt function (#18614)
  api: fix IPC auth (#18612)
  web: bump mermaid from 11.12.1 to 11.12.2 in /web (#18602)
  web: Codemirror fixes (#18610)
  web: bump packages in /web (#18604)
  website/docs: expressions: fix markdown (#18613)
  website/docs: add missing API sidebar entry (#18586)
  web: bump yaml from 2.8.1 to 2.8.2 in /web (#18605)
  web/elements: update AppIcon story with files change (#18608)
  api: test action decorator (#18583)
  crypto: separate permissions for certificate and private keydownload (#18588)
  core: bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (#18592)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Features or issues related to accessibility area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants