Skip to content

lib/sync/outgoing: check if there is a provider before creating tasks#18394

Merged
rissson merged 1 commit intomainfrom
inline-task-check
Nov 26, 2025
Merged

lib/sync/outgoing: check if there is a provider before creating tasks#18394
rissson merged 1 commit intomainfrom
inline-task-check

Conversation

@rissson
Copy link
Member

@rissson rissson commented Nov 26, 2025

Details

Closes #18368
Closes #17648

Not checking is causing too many issues for small instances. Let's bite the bullet of the extra db queries and do it this way.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson added this to the Release 2025.12 milestone Nov 26, 2025
@rissson rissson self-assigned this Nov 26, 2025
@rissson rissson requested a review from a team as a code owner November 26, 2025 17:07
@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c4fd799
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/692733b66f18cd00080e395d

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit c4fd799
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/692733b6a3989e0009e9f510

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c4fd799
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/692733b628ef8b0007a89601
😎 Deploy Preview https://deploy-preview-18394--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.90%. Comparing base (d211ea1) to head (c4fd799).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/providers/oauth2/signals.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18394      +/-   ##
==========================================
- Coverage   92.98%   92.90%   -0.08%     
==========================================
  Files         894      894              
  Lines       48919    48928       +9     
==========================================
- Hits        45486    45456      -30     
- Misses       3433     3472      +39     
Flag Coverage Δ
e2e 45.40% <90.90%> (-0.06%) ⬇️
integration 23.10% <18.18%> (-0.08%) ⬇️
unit 91.09% <90.90%> (-0.01%) ⬇️
unit-migrate 91.14% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Nov 26, 2025
@rissson rissson enabled auto-merge (squash) November 26, 2025 17:26
@rissson rissson added the backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10 label Nov 26, 2025
@rissson rissson moved this from In Progress to Needs review in authentik Core Nov 26, 2025
@rissson rissson moved this from Needs review to In review in authentik Core Nov 26, 2025
@rissson rissson merged commit 0490f53 into main Nov 26, 2025
99 of 100 checks passed
@rissson rissson deleted the inline-task-check branch November 26, 2025 17:33
@github-project-automation github-project-automation bot moved this from In review to Done in authentik Core Nov 26, 2025
authentik-automation bot pushed a commit that referenced this pull request Nov 26, 2025
…#18394)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.10 created: #18397

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c4fd7998cd7bbb23d07739a9f706bd46050e13ce
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c4fd7998cd7bbb23d07739a9f706bd46050e13ce

Afterwards, run the upgrade commands from the latest release notes.

rissson added a commit that referenced this pull request Nov 26, 2025
… (cherry-pick #18394 to version-2025.10) (#18397)

lib/sync/outgoing: check if there is a provider before creating tasks (#18394)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Flooding of Queued System Tasks since 2025.10.0 2025.8.4: loop enqueuing SCIM/Google Workspace/Microsoft Entra sync tasks (not configured)

2 participants