Skip to content

outpost/proxyv2: more tests, fix pg password with spaces, and existing session on restart#18211

Merged
dominic-r merged 5 commits intomainfrom
sdko/fix-pg-pass-spaces-outpost
Dec 11, 2025
Merged

outpost/proxyv2: more tests, fix pg password with spaces, and existing session on restart#18211
dominic-r merged 5 commits intomainfrom
sdko/fix-pg-pass-spaces-outpost

Conversation

@dominic-r
Copy link
Member

And modify / add some more tests and a bit of refactoring

Closes: #18175

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

…characters

And modify / add some more tests and a bit of refactoring
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 335a453
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/693acabf40a1ab0008dc4f99
😎 Deploy Preview https://deploy-preview-18211--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 335a453
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/693acabfb1cbd70008d45b33
😎 Deploy Preview https://deploy-preview-18211--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 335a453
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/693acabf92e353000813e7a0
😎 Deploy Preview https://deploy-preview-18211--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dominic-r dominic-r changed the title outpost/proxyv2: handle PostgreSQL passwords with spaces and special characters outpost/proxyv2: handle PostgreSQL passwords with spaces and special chars + more tests Nov 18, 2025
…te check

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dominic R <dominic@sdko.org>
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (3532999) to head (335a453).
⚠️ Report is 314 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18211      +/-   ##
==========================================
+ Coverage   92.95%   93.21%   +0.25%     
==========================================
  Files         869      946      +77     
  Lines       48116    51768    +3652     
==========================================
+ Hits        44728    48256    +3528     
- Misses       3388     3512     +124     
Flag Coverage Δ
e2e 44.76% <ø> (-0.42%) ⬇️
integration 23.30% <ø> (+0.11%) ⬆️
unit 91.45% <ø> (+0.38%) ⬆️
unit-migrate 91.50% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-335a453d3196aae7c34f74ff3290db17a39e2c3e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-335a453d3196aae7c34f74ff3290db17a39e2c3e

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson added this to the Release 2025.10.3 milestone Nov 18, 2025
@rissson rissson added the backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10 label Nov 18, 2025
@dominic-r dominic-r changed the title outpost/proxyv2: handle PostgreSQL passwords with spaces and special chars + more tests outpost/proxyv2: more tests, fix pg password with spaces, and existing session on restart Nov 23, 2025
@dominic-r dominic-r linked an issue Nov 23, 2025 that may be closed by this pull request
@rissson rissson requested a review from BeryJu November 24, 2025 15:02
@dominic-r dominic-r removed the request for review from melizeche November 24, 2025 15:28
@rissson rissson moved this from Todo to In review in authentik Core Dec 10, 2025
@rissson rissson moved this from In review to Needs review in authentik Core Dec 10, 2025
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-project-automation github-project-automation bot moved this from Needs review to In Progress in authentik Core Dec 11, 2025
@dominic-r dominic-r enabled auto-merge (squash) December 11, 2025 14:07
@dominic-r dominic-r merged commit 3353db0 into main Dec 11, 2025
135 of 137 checks passed
@dominic-r dominic-r deleted the sdko/fix-pg-pass-spaces-outpost branch December 11, 2025 14:25
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Dec 11, 2025
authentik-automation bot pushed a commit that referenced this pull request Dec 11, 2025
…g session on restart (#18211)

* outpost/proxyv2: handle PostgreSQL passwords with spaces and special characters

And modify / add some more tests and a bit of refactoring

* Potential fix for code scanning alert no. 268: Disabled TLS certificate check

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dominic R <dominic@sdko.org>

* Revert "Potential fix for code scanning alert no. 268: Disabled TLS certificate check"

This reverts commit ead227a.

* wip

* fix incorrect status code in error response

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Dominic R <dominic@sdko.org>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Jens Langhammer <jens@goauthentik.io>
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.10 created: #18742

rissson pushed a commit that referenced this pull request Dec 11, 2025
…g session on restart (cherry-pick #18211 to version-2025.10) (#18742)

Co-authored-by: Dominic R <dominic@sdko.org>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Jens Langhammer <jens@goauthentik.io>
fix pg password with spaces, and existing session on restart (#18211)
kensternberg-authentik added a commit that referenced this pull request Dec 11, 2025
* main: (69 commits)
  website/docs: fix incorrect menu reference in data exports doc (#18752)
  translate: Updates for project authentik and language zh-Hans (#18756)
  translate: Updates for project authentik and language tr_TR (#18758)
  translate: Updates for project authentik and language fi_FI (#18759)
  translate: Updates for project authentik and language pl_PL (#18754)
  translate: Updates for project authentik and language ru_RU (#18745)
  translate: Updates for project authentik and language ko_KR (#18760)
  translate: Updates for project authentik and language ja_JP (#18755)
  translate: Updates for project authentik and language de_DE (#18749)
  translate: Updates for project authentik and language nl_NL (#18751)
  translate: Updates for project authentik and language pt_BR (#18746)
  translate: Updates for project authentik and language es_ES (#18748)
  translate: Updates for project authentik and language it_IT (#18750)
  translate: Updates for project authentik and language cs_CZ (#18753)
  translate: Updates for project authentik and language fr_FR (#18747)
  stages/identification: Add WebAuthn conditional UI (passkey autofill) support (#18377)
  api: allow configuring default page_size and max_page_size (#18165)
  root: do not require backend approval for npm workspace dependencies (#18738)
  outpost/proxyv2: more tests, fix pg password with spaces, and existing session on restart (#18211)
  web: bump @types/guacamole-common-js from 1.5.4 to 1.5.5 in /web (#18717)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend backport/version-2025.10 Add this label to PRs to backport changes to version-2025.10

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Proxy outpost in authentik 2025.10 fails with spaces in Postgres password Proxy Outpost Basic Auth 2025.10.x Breaks after Outpost Restart

4 participants