stages/user_write: Fix user attributes are not sanitized under certains conditions#17890
Merged
BeryJu merged 2 commits intogoauthentik:mainfrom Dec 1, 2025
Merged
stages/user_write: Fix user attributes are not sanitized under certains conditions#17890BeryJu merged 2 commits intogoauthentik:mainfrom
BeryJu merged 2 commits intogoauthentik:mainfrom
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
needs tests @BeryJu |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17890 +/- ##
==========================================
+ Coverage 92.64% 92.97% +0.32%
==========================================
Files 869 911 +42
Lines 47960 49775 +1815
==========================================
+ Hits 44431 46276 +1845
+ Misses 3529 3499 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
approved these changes
Dec 1, 2025
kensternberg-authentik
added a commit
that referenced
this pull request
Dec 11, 2025
* main: (53 commits) core, web: update translations (#18380) web: re-add en.xlf locale (#18469) stages/user_write: Fix user attributes are not sanitized under certains conditions (#17890) providers/scim: compare users/groups before sending update request (#18456) enterprise/endpoints/connectors/agent: fix Apple JWE encryption when FIPS is enabled (#18464) website: bump @types/react from 19.2.6 to 19.2.7 in /website (#18357) core: bump goauthentik/fips-debian from `ac4c80b` to `de70579` (#18419) core: bump github.com/getsentry/sentry-go from 0.39.0 to 0.40.0 (#18416) website: bump prettier-plugin-packagejson from 2.5.19 to 2.5.20 in /website (#18460) core: bump goauthentik.io/api/v3 from 3.2025120.7 to 3.2025120.11 (#18461) website/integrations: add GLPI (#17937) website/integrations: small fixes (#18423) enterprise: Apple Platform SSO (#15318) crypto: only generate managed keypair if non-existent (#18457) ci: remove translation-rename (#18444) translate: Updates for project authentik and language tr (#18438) translate: Updates for project authentik and language fr (#18431) translate: Updates for project authentik and language ru (#18442) translate: Updates for project authentik and language cs_CZ (#18443) translate: Updates for project authentik and language pt (#18437) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes a case where certain prompt types (like the date prompt) lead to a failure in the user write stage, because of unsanitized attributes. The original issue was reported in #8708 and later fixed in #8926. However, the fix in #8926 only worked if the prompt would write to
attributes_fooorattributes.foo.bar. If the normal syntax is usedattributes.foothe stage would try to directly update the user attributes, which lead to unsanitized values. This PR fixes that case.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)