Skip to content

provider/saml: make signing kp singleton#17703

Merged
PeshekDotDev merged 1 commit intomainfrom
saml-keypair
Oct 30, 2025
Merged

provider/saml: make signing kp singleton#17703
PeshekDotDev merged 1 commit intomainfrom
saml-keypair

Conversation

@PeshekDotDev
Copy link
Contributor

Details

Making signing KP singleton helps put a default key to help aid the provider configuration process for SAML


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@netlify
Copy link

netlify bot commented Oct 25, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 60c8227
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68fc5c36da36680009c8a8c1
😎 Deploy Preview https://deploy-preview-17703--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 25, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 60c8227
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68fc5c361d71870008081d75
😎 Deploy Preview https://deploy-preview-17703--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 25, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 60c8227
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68fc5c3626b0c90008a455bd

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (5e4c9ad) to head (60c8227).
⚠️ Report is 51 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17703      +/-   ##
==========================================
- Coverage   92.98%   92.93%   -0.06%     
==========================================
  Files         869      869              
  Lines       47949    47949              
==========================================
- Hits        44584    44560      -24     
- Misses       3365     3389      +24     
Flag Coverage Δ
e2e 45.26% <ø> (-0.02%) ⬇️
integration 23.11% <ø> (-0.07%) ⬇️
unit 91.07% <ø> (+<0.01%) ⬆️
unit-migrate 91.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-60c8227dc4af42648d44a8343fd676a3b9e70128
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-60c8227dc4af42648d44a8343fd676a3b9e70128

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu added this to the Release 2025.12 milestone Oct 27, 2025
@PeshekDotDev PeshekDotDev marked this pull request as ready for review October 27, 2025 19:48
@PeshekDotDev PeshekDotDev requested a review from a team as a code owner October 27, 2025 19:48
@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Oct 29, 2025
@PeshekDotDev PeshekDotDev merged commit b65d163 into main Oct 30, 2025
100 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Oct 30, 2025
@PeshekDotDev PeshekDotDev deleted the saml-keypair branch October 30, 2025 19:25
kensternberg-authentik added a commit that referenced this pull request Nov 10, 2025
* main: (32 commits)
  website/docs: 2025.10.1 release notes (#17918)
  providers/oauth2: fix kid always required for federation (#17914)
  providers/radius: revert fix inverted message authenticator validation (#17855) (#17915)
  website: bump @types/node from 24.9.1 to 24.9.2 in /website (#17786)
  web: bump @rollup/plugin-commonjs from 28.0.8 to 28.0.9 in /web in the rollup group across 1 directory (#17788)
  web: bump validator from 13.15.15 to 13.15.20 in /packages/docusaurus-config (#17866)
  internal: add default go http server timeouts (#17858)
  providers/radius: fix inverted message authenticator validation (#17855)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#17871)
  web: fix package-lock.json (#17809)
  website/integrations: oracle cloud: cleanup (#17808)
  website/integrations: Add Keycloak integration (#17813)
  website: bump the build group across 1 directory with 9 updates (#17849)
  lifecycle/aws: bump aws-cdk from 2.1031.0 to 2.1031.1 in /lifecycle/aws (#17850)
  core: bump astral-sh/uv from 0.9.6 to 0.9.7 (#17851)
  internal: full openssl path (#17856)
  outpost: revert breaking signals change (#17847)
  web/a11y: Isolated Outpost Error Page (#17683)
  provider/saml: make signing kp singleton (#17703)
  tasks: sanitize log attributes (#17833)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants