Skip to content

packages/django-dramatiq-postgres: broker: task retrieval fixes and improvements#17335

Merged
rissson merged 3 commits intomainfrom
rework-broker
Oct 9, 2025
Merged

packages/django-dramatiq-postgres: broker: task retrieval fixes and improvements#17335
rissson merged 3 commits intomainfrom
rework-broker

Conversation

@rissson
Copy link
Member

@rissson rissson commented Oct 8, 2025 •
edited
Loading

Details

  • properly deals with database issues
  • makes sure that we don't block when we have too many tasks in processing (which could occur because we didn't properly keep track of message ids)
  • unlocks messages inline, with a backup in case of database problems
  • runs the scheduler and unlocking processes before picking up tasks, to ensure they always get run in time and never fall behind because of new tasks being scheduled
  • improves indexes to match what we select on
  • gets rid of the delay queue to instead use the eta field on the database

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@rissson
packages/django-dramatiq-postgres: broker: task retrieval fixes and i…
e098679 
…mprovements

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Oct 8, 2025
@rissson rissson requested a review from a team as a code owner October 8, 2025 17:07
@netlify
Copy link

netlify bot commented Oct 8, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 7db9421
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68e69db9fbc6c10008d044f4

@netlify
Copy link

netlify bot commented Oct 8, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7db9421
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68e69dbbd5daf20008a448e7

@netlify
Copy link

netlify bot commented Oct 8, 2025 •
edited
Loading

✅ Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 7db9421
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68e69db9afd79700085e22a1

@rissson
add missing migration
7f008fb 
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (a4a6c1f) to head (7db9421).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17335      +/-   ##
==========================================
+ Coverage   92.95%   92.97%   +0.01%     
==========================================
  Files         855      855              
  Lines       46511    46511              
==========================================
+ Hits        43236    43242       +6     
+ Misses       3275     3269       -6
Flag Coverage Δ
e2e 46.07% <ø> (+0.01%) ⬆️
integration 23.12% <ø> (+<0.01%) ⬆️
unit 91.04% <ø> (+<0.01%) ⬆️
unit-migrate 91.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson
lint
7db9421 
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-7db9421b3439b889a52f54ecac494afe0cc8a679
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-7db9421b3439b889a52f54ecac494afe0cc8a679

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit c8caeef into main Oct 9, 2025
136 of 139 checks passed
@rissson rissson deleted the rework-broker branch October 9, 2025 11:22
kensternberg-authentik added a commit that referenced this pull request Nov 10, 2025
@kensternberg-authentik
Merge branch 'main' into dev
47ed22b 
* main: (56 commits)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#17361)
  website/docs: add entra id scim source (#17357)
  outpost: proxyv2: Use Postgres for the Embedded Outpost (#16628)
  tasks: set uid early (#17356)
  tasks: only set tenant on task creation (#17358)
  core: bump golang.org/x/oauth2 from 0.31.0 to 0.32.0 (#17346)
  web: bump eslint-plugin-react-hooks from 6.1.1 to 7.0.0 in /packages/eslint-config in the eslint group across 1 directory (#17347)
  web: bump chromedriver from 141.0.0 to 141.0.1 in /web (#17348)
  web: bump knip from 5.64.1 to 5.64.2 in /web (#17349)
  web: bump @formatjs/intl-listformat from 7.7.11 to 7.7.12 in /web (#17350)
  web: bump pino from 9.13.0 to 10.0.0 in /web (#17351)
  core: bump axllent/mailpit from v1.27.9 to v1.27.10 in /tests/e2e (#17352)
  enterprise/providers/gws+entra: fix group integrity error during discovery (#17355)
  core, web: update translations (#17342)
  ci: bump snok/container-retention-policy from 2.2.1 to 3.0.1 (#17344)
  core: bump goauthentik.io/api/v3 from 3.2025100.18 to 3.2025100.20 (#17345)
  packages/django-dramatiq-postgres: broker: task retrieval fixes and improvements (#17335)
  enterprise/providers/gws+entra: fix integrity error during discovery (#17341)
  web: bump API Client version (#17340)
  api: Clean schema up more (#17055)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeryJu BeryJu BeryJu approved these changes

Assignees

@rissson rissson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rissson @BeryJu