web: Improvements to ReCaptcha resizing #16171
Merged
GirlBossRush merged 3 commits intomainfrom Aug 18, 2025
Merged
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16171 +/- ##
=======================================
Coverage 92.77% 92.78%
=======================================
Files 836 836
Lines 45213 45213
=======================================
+ Hits 41946 41949 +3
+ Misses 3267 3264 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
approved these changes
Aug 15, 2025
Contributor
kensternberg-authentik
left a comment
There was a problem hiding this comment.
So much fiddling.
ce70012 to
720907d
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-720907d346f08e6497f720c24d65636e8c9e7437
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-720907d346f08e6497f720c24d65636e8c9e7437Afterwards, run the upgrade commands from the latest release notes. |
GirlBossRush
added a commit
that referenced
this pull request
Aug 20, 2025
* web: Remove comments from serialized HTML. * web: Apply color theme to iframe. * web: Fix issues surrounding reCaptcha resize events not propagating.
rissson
pushed a commit
that referenced
this pull request
Aug 21, 2025
This was referenced Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR focuses on a few visual issues that arise in the Captcha stage when using ReCaptcha.
As reported in #15598, Recaptcha v2 and v3 do not resize in response to their parent iframe's change in height. Additionally, ReCaptcha's (latest?) logic for handling domain verification isn't compatible with our switch to blob URLs as a source for frames.
The current fix for this limited due to the nature of this three-layer deep iframe structure.
We have a few options for fixing this:
This PR uses option 2, expanding our existing resize logic to traverse the DOM tree and resize all relevant elements. This is a bit of a hack, and it's limited to expanding the captcha's iframe, but it has the least impact on the other captcha vendors.
Also included is a fix captcha iframes not inheriting the color scheme of the parent page, ensuring fewer slivers of white around the captcha.
What's not included
sizeparameterCloses #15598