Skip to content

web/a11y: Codemirror#16010

Merged
GirlBossRush merged 2 commits intomainfrom
a11y-codemirror
Sep 10, 2025
Merged

web/a11y: Codemirror#16010
GirlBossRush merged 2 commits intomainfrom
a11y-codemirror

Conversation

@GirlBossRush
Copy link
Contributor

@GirlBossRush GirlBossRush commented Aug 6, 2025

Details

This PR resolves a collection of accessibility issues in the Codemirror web component. In addition to fleshing out Codemirror's lifecycle with Lit, our element now makes use of ElementInternals, allowing for a more native form input serialization.

See also

@GirlBossRush GirlBossRush requested a review from a team as a code owner August 6, 2025 17:16
@netlify
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 4377105
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68c1d36c3bacc60008c24109
😎 Deploy Preview https://deploy-preview-16010--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 4377105
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68c1d36c9730dc0008d83a94
😎 Deploy Preview https://deploy-preview-16010--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 4377105
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68c1d36c2a84fa0008099db8
😎 Deploy Preview https://deploy-preview-16010--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.82%. Comparing base (37d8ccd) to head (4377105).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16010   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         838      838           
  Lines       45367    45367           
=======================================
+ Hits        42112    42113    +1     
+ Misses       3255     3254    -1     
Flag Coverage Δ
e2e 46.57% <ø> (+<0.01%) ⬆️
integration 23.51% <ø> (+<0.01%) ⬆️
unit 90.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GirlBossRush GirlBossRush added the a11y Features or issues related to accessibility label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-eba0d1724d07d54c5401747444b5b8b03151317f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-eba0d1724d07d54c5401747444b5b8b03151317f

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the non-standard binary issue.

@GirlBossRush GirlBossRush enabled auto-merge (squash) September 10, 2025 20:02
@GirlBossRush GirlBossRush merged commit 62918e9 into main Sep 10, 2025
150 of 154 checks passed
@GirlBossRush GirlBossRush deleted the a11y-codemirror branch September 10, 2025 20:21
PeshekDotDev pushed a commit that referenced this pull request Sep 11, 2025
* web: Make Codemirror screen reader friendly.

* web: Include shared directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Features or issues related to accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants