Skip to content

web: Fix intermediate wizard steps propagating refresh events to parent#15548

Merged
GirlBossRush merged 2 commits intomainfrom
fix-wizard-form-events
Jul 15, 2025
Merged

web: Fix intermediate wizard steps propagating refresh events to parent#15548
GirlBossRush merged 2 commits intomainfrom
fix-wizard-form-events

Conversation

@GirlBossRush
Copy link
Contributor

…rerenders.

Details

  1. User clicks modal button within an element which subscribes to refresh.
  2. Opens modal form
  3. User navigates to a step which contains a form submission, that also isn’t the last step
  4. Refresh triggers, causing the whole modal button to reload

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@GirlBossRush GirlBossRush self-assigned this Jul 14, 2025
@GirlBossRush GirlBossRush requested a review from a team as a code owner July 14, 2025 14:22
@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 3f5e434
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68752418355d1500085e764e

@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 3f5e434
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68752418460b09000974e842
😎 Deploy Preview https://deploy-preview-15548--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 3f5e434
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68752418753c8600087d9063

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (15b556c) to head (3f5e434).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15548      +/-   ##
==========================================
+ Coverage   93.01%   93.15%   +0.14%     
==========================================
  Files         824      831       +7     
  Lines       42819    44135    +1316     
==========================================
+ Hits        39826    41116    +1290     
- Misses       2993     3019      +26     
Flag Coverage Δ
e2e 46.64% <ø> (-0.84%) ⬇️
integration 23.50% <ø> (-0.69%) ⬇️
unit 91.25% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-3f5e434c77472c9f1d0c9671ef74fd50b2ccb018
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-3f5e434c77472c9f1d0c9671ef74fd50b2ccb018

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not comfortable with the language change of "step" to "listener"; feels like that exposes an internal how rather than a semantic why. Still, I don't think my feelings should block merging.

Signed-off-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
@GirlBossRush GirlBossRush force-pushed the fix-wizard-form-events branch from 4431ebb to 3f5e434 Compare July 14, 2025 15:36
@GirlBossRush GirlBossRush changed the title web: Fix wizard intermediate wizard steps propagating refresh events to parent web: Fix intermediate wizard steps propagating refresh events to parent Jul 15, 2025
@GirlBossRush GirlBossRush merged commit 6cab1f8 into main Jul 15, 2025
106 of 107 checks passed
@GirlBossRush GirlBossRush deleted the fix-wizard-form-events branch July 15, 2025 00:28
tanberry pushed a commit to stazio/authentik that referenced this pull request Jul 24, 2025
…nt (goauthentik#15548)

* web: Fix issue where wizard steps with refresh events trigger parent rerenders.

* Apply suggestions from code review. Tidy.

Signed-off-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>

---------

Signed-off-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants