Skip to content

stages/email: only update is_active on user to not overwrite external changes#15508

Merged
BeryJu merged 2 commits intomainfrom
stages/email/partial-write-user
Jul 15, 2025
Merged

stages/email: only update is_active on user to not overwrite external changes#15508
BeryJu merged 2 commits intomainfrom
stages/email/partial-write-user

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 10, 2025

Details

Due to the entire user object being stored in the flow context, when it is modified externally during a flow execution, data such as attributes can be lost


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner July 10, 2025 16:19
@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit c0ad439
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68750a85bb97fc0008c47b93

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c0ad439
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68750a85b1c6140008d1a666
😎 Deploy Preview https://deploy-preview-15508--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit c0ad439
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68750a85b121210008c24d52
😎 Deploy Preview https://deploy-preview-15508--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (6c93934) to head (c0ad439).
Report is 17 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15508      +/-   ##
==========================================
+ Coverage   93.19%   93.21%   +0.02%     
==========================================
  Files         831      831              
  Lines       44135    44144       +9     
==========================================
+ Hits        41133    41151      +18     
+ Misses       3002     2993       -9     
Flag Coverage Δ
e2e 46.76% <41.66%> (+0.77%) ⬆️
integration 23.49% <0.00%> (-0.01%) ⬇️
unit 91.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c0ad439c10406a0022fb66c5690a92e3ab4f37d0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c0ad439c10406a0022fb66c5690a92e3ab4f37d0

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the stages/email/partial-write-user branch 2 times, most recently from 2b1cb67 to 466bc9d Compare July 11, 2025 20:00
BeryJu added 2 commits July 14, 2025 15:47
… changes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the stages/email/partial-write-user branch from 111676a to c0ad439 Compare July 14, 2025 13:47
@BeryJu BeryJu merged commit a088a62 into main Jul 15, 2025
107 checks passed
@BeryJu BeryJu deleted the stages/email/partial-write-user branch July 15, 2025 14:43
GirlBossRush pushed a commit that referenced this pull request Jul 15, 2025
… changes (#15508)

* stages/email: only update is_active on user to not overwrite external changes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* respect update_fields for diff

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
GirlBossRush pushed a commit that referenced this pull request Jul 15, 2025
… changes (#15508)

* stages/email: only update is_active on user to not overwrite external changes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* respect update_fields for diff

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
tanberry pushed a commit to stazio/authentik that referenced this pull request Jul 24, 2025
… changes (goauthentik#15508)

* stages/email: only update is_active on user to not overwrite external changes

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* respect update_fields for diff

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant