Skip to content

tests/e2e: fix flaky SAML Source test#14708

Merged
rissson merged 8 commits intomainfrom
tests/e2e/fix-saml-flaky
May 27, 2025
Merged

tests/e2e: fix flaky SAML Source test#14708
rissson merged 8 commits intomainfrom
tests/e2e/fix-saml-flaky

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented May 27, 2025

Details

From testing, the main thing that causes this test to break is the chrome password leak thingy; it seems to block all interactions from selenium until dismissed and is obviously not helpful while testing locally. Sometimes selenium is fast enoug/chrome is slow enough for us to send the signal to click on the button before the warning pops up and we succeed.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner May 27, 2025 00:31
@netlify
Copy link

netlify bot commented May 27, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit a3a9893
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68351576015c710008481986

@netlify
Copy link

netlify bot commented May 27, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a3a9893
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/683515762fddc30008de6d51
😎 Deploy Preview https://deploy-preview-14708--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (c6333f9) to head (a3a9893).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14708      +/-   ##
==========================================
+ Coverage   92.43%   92.75%   +0.31%     
==========================================
  Files         814      814              
  Lines       41901    41901              
==========================================
+ Hits        38733    38865     +132     
+ Misses       3168     3036     -132     
Flag Coverage Δ
e2e 47.77% <ø> (+1.25%) ⬆️
integration 24.42% <ø> (ø)
unit 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BeryJu BeryJu requested a review from a team as a code owner May 27, 2025 00:42
@BeryJu BeryJu force-pushed the tests/e2e/fix-saml-flaky branch from bfde805 to 4954942 Compare May 27, 2025 00:47
BeryJu added 8 commits May 27, 2025 03:29
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
?
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the tests/e2e/fix-saml-flaky branch from 95722cd to a3a9893 Compare May 27, 2025 01:29
@rissson rissson merged commit 15d84d3 into main May 27, 2025
97 of 99 checks passed
@rissson rissson deleted the tests/e2e/fix-saml-flaky branch May 27, 2025 11:18
kensternberg-authentik added a commit that referenced this pull request Jun 6, 2025
* main: (27 commits)
  lib/sync/outgoing: sync in parallel (#14697)
  core, web: update translations (#14707)
  tests/e2e: fix flaky SAML Source test (#14708)
  web: fix lock (#14705)
  Update packages-npm-publish.yml (#14702)
  website/integrations: coder: fix typo (#14514)
  ci: Update packages-npm-publish.yml (#14701)
  web: bump the swc group across 2 directories with 12 updates (#14623)
  web: Use engine available on Github Actions. (#14699)
  web: bump the rollup group across 1 directory with 4 updates (#14682)
  ci: test with postgres 17 (#13967)
  web: bump knip from 5.33.0 to 5.58.0 in /web (#14685)
  web: bump fuse.js from 7.0.0 to 7.1.0 in /web (#14687)
  web: bump @formatjs/intl-listformat from 7.5.7 to 7.7.11 in /web (#14689)
  root: do not use /bin/bash directly (#14698)
  website/integrations: minio: notice about sso deprecation on CE (#14679)
  core: bump cryptography from 44.0.3 to 45.0.3 (#14690)
  core: bump django-tenants from 3.7.0 to 3.8.0 (#14691)
  core: bump astral-sh/uv from 0.7.7 to 0.7.8 (#14681)
  core: bump axllent/mailpit from v1.25.0 to v1.25.1 in /tests/e2e (#14693)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants