Skip to content

sources/scim: fix all users being added to group when no members are given#14645

Merged
BeryJu merged 1 commit intomainfrom
sources/scim/only-update-members-when-filtered
May 23, 2025
Merged

sources/scim: fix all users being added to group when no members are given#14645
BeryJu merged 1 commit intomainfrom
sources/scim/only-update-members-when-filtered

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented May 22, 2025

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…given

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 22, 2025 16:09
@netlify
Copy link

netlify bot commented May 22, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 7d6d94e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/682f4c514c488100080b73bf
😎 Deploy Preview https://deploy-preview-14645--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented May 22, 2025

Deploy Preview for authentik-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit 7d6d94e
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/682f4c5156ebe80008db53fb

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (4a74db1) to head (7d6d94e).
Report is 69 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/scim/views/v2/groups.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14645      +/-   ##
==========================================
- Coverage   92.76%   92.70%   -0.06%     
==========================================
  Files         809      814       +5     
  Lines       41529    41901     +372     
==========================================
+ Hits        38525    38846     +321     
- Misses       3004     3055      +51     
Flag Coverage Δ
e2e 47.69% <50.00%> (-0.26%) ⬇️
integration 24.42% <0.00%> (+0.01%) ⬆️
unit 90.58% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-7d6d94e87aaa2f937161f12afd9e894475db8fde
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-7d6d94e87aaa2f937161f12afd9e894475db8fde

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 67c31a8 into main May 23, 2025
87 of 92 checks passed
@BeryJu BeryJu deleted the sources/scim/only-update-members-when-filtered branch May 23, 2025 11:57
@BeryJu
Copy link
Member Author

BeryJu commented May 23, 2025

/cherry-pick version-2025.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 23, 2025
…given (#14645)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request May 23, 2025
…given (cherry-pick #14645) (#14666)

sources/scim: fix all users being added to group when no members are given (#14645)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jun 6, 2025
* main: (24 commits)
  web: Type Tidy (#14647)
  core: bump pydantic from 2.11.4 to 2.11.5 (#14652)
  core: bump google-api-python-client from 2.169.0 to 2.170.0 (#14653)
  sources/scim: fix all users being added to group when no members are given (#14645)
  web: bump @codemirror/lang-javascript from 6.2.2 to 6.2.4 in /web (#14657)
  web: bump @types/node from 22.15.19 to 22.15.21 in /web (#14660)
  core: bump astral-sh/uv from 0.7.6 to 0.7.7 (#14651)
  web: bump wireit from 0.14.9 to 0.14.12 in /web (#14656)
  web: bump country-flag-icons from 1.5.13 to 1.5.19 in /web (#14659)
  web: bump @trivago/prettier-plugin-sort-imports from 4.3.0 to 5.2.2 in /web (#14661)
  web: bump chart.js from 4.4.4 to 4.4.9 in /web (#14655)
  website: bump the goauthentik group in /website with 3 updates (#14654)
  web: bump dompurify from 3.2.4 to 3.2.6 in /web (#14658)
  web: fix lint (#14665)
  website/docs: improve-rac-documents (#14414)
  web: bump the rollup group across 2 directories with 3 updates (#14622)
  web: bump the sentry group across 1 directory with 2 updates (#14587)
  lifecycle/aws: bump aws-cdk from 2.1016.0 to 2.1016.1 in /lifecycle/aws (#14631)
  web: bump @patternfly/elements from 4.0.2 to 4.1.0 in /web (#14634)
  web: bump @lit/task from 1.0.1 to 1.0.2 in /web (#14635)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant