Skip to content

Revert "core: fix non-exploitable open redirect (#13696)"#13824

Merged
rissson merged 1 commit intomainfrom
revert-13696
Apr 8, 2025
Merged

Revert "core: fix non-exploitable open redirect (#13696)"#13824
rissson merged 1 commit intomainfrom
revert-13696

Conversation

@rissson
Copy link
Member

@rissson rissson commented Apr 8, 2025

This reverts commit 63a118a.

Details

REPLACE ME

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Apr 8, 2025
@rissson rissson requested a review from a team as a code owner April 8, 2025 16:55
@netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 287f32f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67f5551ae2207f000870598a

@netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 287f32f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67f5551a310bd00008dc21c4

@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (36cecc1) to head (287f32f).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13824      +/-   ##
==========================================
- Coverage   92.80%   92.79%   -0.01%     
==========================================
  Files         796      796              
  Lines       40761    40755       -6     
==========================================
- Hits        37828    37820       -8     
- Misses       2933     2935       +2
Flag Coverage Δ
e2e 47.91% <ø> (+0.03%) ⬆️
integration 24.17% <ø> (+<0.01%) ⬆️
unit 90.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rissson
Copy link
Member Author

rissson commented Apr 8, 2025

/cherry-pick version-2025.2

@rissson
Copy link
Member Author

rissson commented Apr 8, 2025

/cherry-pick version-2024.12

@rissson rissson enabled auto-merge (squash) April 8, 2025 17:03
@rissson rissson merged commit 7d054db into main Apr 8, 2025
89 checks passed
@rissson rissson deleted the revert-13696 branch April 8, 2025 17:10
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 8, 2025
@rissson
Revert "core: fix non-exploitable open redirect (#13696)" (#13824)
0e1e0bb
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 8, 2025
Merged
@gcp-cherry-pick-bot
Copy link
Contributor

gcp-cherry-pick-bot bot commented Apr 8, 2025

Cherry-pick failed with Merge error 7d054db1a562fa65fe96f12d31697bf4839b279e into temp-cherry-pick-e737e7-version-2024.12

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-287f32f32d30fd121f7f052c92fb32708dfe370c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-287f32f32d30fd121f7f052c92fb32708dfe370c

Afterwards, run the upgrade commands from the latest release notes.

rissson added a commit that referenced this pull request Apr 8, 2025
@gcp-cherry-pick-bot @rissson
Revert "core: fix non-exploitable open redirect (#13696)" (cherry-pick …
06137fc 
…#13824) (#13826)

Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
fix non-exploitable open redirect (#13696)" (#13824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melizeche melizeche melizeche approved these changes

Assignees

@rissson rissson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rissson @melizeche