web/user: ensure modal container on user-settings page is min-height: 100% (cherry-pick #13402)#13413
Merged
BeryJu merged 1 commit intoversion-2025.2from Mar 6, 2025
Merged
Conversation
… 100% (#13402) * web: Add InvalidationFlow to Radius Provider dialogues ## What - Bugfix: adds the InvalidationFlow to the Radius Provider dialogues - Repairs: `{"invalidation_flow":["This field is required."]}` message, which was *not* propagated to the Notification. - Nitpick: Pretties `?foo=${true}` expressions: `s/\?([^=]+)=\$\{true\}/\1/` ## Note Yes, I know I'm going to have to do more magic when we harmonize the forms, and no, I didn't add the Property Mappings to the wizard, and yes, I know I'm going to have pain with the *new* version of the wizard. But this is a serious bug; you can't make Radius servers with *either* of the current dialogues at the moment. * This (temporary) change is needed to prevent the unit tests from failing. \# What \# Why \# How \# Designs \# Test Steps \# Other Notes * Revert "This (temporary) change is needed to prevent the unit tests from failing." This reverts commit dddde09. * web/admin: ensure modal container on user-settings page is min-height: 100% ## What Add a min-height and auto-scroll directives to the CSS for the main section of the user-settings page. ``` + .pf-c-page__main { + min-height: 100vw; + overflow-y: auto; ``` ## Why Without this, Safari refused to render any pop-up modals that were "centered" on the viewport but were "beneath" the rendered content space of the container. As a result, users could not create new access tokens or app passwords. This is arguably incorrect behavior on Safari's part, but 🤷♀️. Adding `overflow-y: auto` on the container means that if the page is not long enough to host the pop-up, it will be accessible via scrolling. ## Testing - Using Safari, Visit the User->User Settings, click "Tokens and App Passwords" tab, and click "Create Token" or "Create App Password" - Observe that the dialog is now accessible. ## Related Issue: - [Unable to create API token in Safari #12891](#12891) * Fix a really stupid typo.
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## version-2025.2 #13413 +/- ##
==================================================
- Coverage 92.74% 92.73% -0.01%
==================================================
Files 793 793
Lines 40268 40268
==================================================
- Hits 37345 37341 -4
- Misses 2923 2927 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-13330707760e8e250a65e0d6dfb91540ededdb0f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-13330707760e8e250a65e0d6dfb91540ededdb0fAfterwards, run the upgrade commands from the latest release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked web/user: ensure modal container on user-settings page is min-height: 100% (#13402)
What
{"invalidation_flow":["This field is required."]}message, which was not propagatedto the Notification.
?foo=${true}expressions:s/\?([^=]+)=\$\{true\}/\1/Note
Yes, I know I'm going to have to do more magic when we harmonize the forms, and no, I didn't add the
Property Mappings to the wizard, and yes, I know I'm going to have pain with the new version of
the wizard. But this is a serious bug; you can't make Radius servers with either of the current
dialogues at the moment.
# What
# Why
# How
# Designs
# Test Steps
# Other Notes
This reverts commit dddde09.
What
Add a min-height and auto-scroll directives to the CSS for the main section of the user-settings
page.
Why
Without this, Safari refused to render any pop-up modals that were "centered" on the viewport but
were "beneath" the rendered content space of the container. As a result, users could not create new
access tokens or app passwords. This is arguably incorrect behavior on Safari's part, but 🤷♀️.
Adding
overflow-y: autoon the container means that if the page is not long enough to host thepop-up, it will be accessible via scrolling.
Testing
"Create Token" or "Create App Password"
Related Issue:
#12891