Skip to content

stages/email: token_expiry format#13394

Merged
melizeche merged 13 commits intomainfrom
stages/email_expiry_format
Mar 11, 2025
Merged

stages/email: token_expiry format#13394
melizeche merged 13 commits intomainfrom
stages/email_expiry_format

Conversation

@melizeche
Copy link
Member

@melizeche melizeche commented Mar 4, 2025

Changes

  • Changed token_expiry field from IntegerField to TextField with string format
  • Added data migration to convert existing integer values to "minutes={value}"
  • Updated UI form to accept text input with format explanation
  • Modified token generation logic to parse the string format

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@melizeche melizeche requested review from a team as code owners March 4, 2025 23:59
@netlify
Copy link

netlify bot commented Mar 4, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 84444e2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67d052b94827b50008c421c2

@netlify
Copy link

netlify bot commented Mar 4, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 84444e2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67d052b9b9873a000855f2d2
😎 Deploy Preview https://deploy-preview-13394--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (ef4d532) to head (84444e2).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #13394       +/-   ##
===========================================
+ Coverage   41.30%   92.68%   +51.38%     
===========================================
  Files         791      793        +2     
  Lines       40113    40378      +265     
===========================================
+ Hits        16567    37423    +20856     
+ Misses      23546     2955    -20591
Flag Coverage Δ
e2e 47.88% <100.00%> (+6.58%) ⬆️
integration 24.07% <75.00%> (?)
unit 90.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-84444e256640a9625b30fc070e9258a9202b828d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-84444e256640a9625b30fc070e9258a9202b828d

Afterwards, run the upgrade commands from the latest release notes.

rissson
rissson requested changes Mar 5, 2025
View reviewed changes
melizeche and others added 3 commits March 5, 2025 15:53
@melizeche @rissson
Update web/src/admin/stages/email/EmailStageForm.ts
bb06223 
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marcelo Elizeche Landó <marce@melizeche.com>
@melizeche
Use db_alias and using() for the queries
40a4ea5
@melizeche
Merge branch 'stages/email_expiry_format' of github.com:goauthentik/a…
a8e0333 
…uthentik into stages/email_expiry_format
BeryJu
BeryJu reviewed Mar 6, 2025
View reviewed changes
@notion-workspace
Copy link

notion-workspace bot commented Mar 7, 2025

Email Stage token_expiry format migration

@melizeche melizeche requested review from BeryJu and rissson March 10, 2025 17:38
@BeryJu
fix missing import
84444e2 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@melizeche melizeche merged commit b0671e2 into main Mar 11, 2025
90 checks passed
@melizeche melizeche deleted the stages/email_expiry_format branch March 11, 2025 16:22
kensternberg-authentik added a commit that referenced this pull request Apr 25, 2025
@kensternberg-authentik
Merge branch 'main' into dev
9251e60 
* main:
  stages/email: token_expiry format (#13394)
  core, web: update translations (#13438)
  website/docs: in developer docs replace deprecated poetry shell command (#13460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeryJu BeryJu BeryJu approved these changes

@rissson rissson rissson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melizeche @BeryJu @rissson