Skip to content

sources: fix saving source in identification stage no longer appears as saved when reopening modal #13005

Closed
dominic-r wants to merge 2 commits intogoauthentik:mainfrom
dominic-r:sdko/sources/fix-source-saving
Closed

sources: fix saving source in identification stage no longer appears as saved when reopening modal #13005
dominic-r wants to merge 2 commits intogoauthentik:mainfrom
dominic-r:sdko/sources/fix-source-saving

Conversation

@dominic-r
Copy link
Member

@dominic-r dominic-r commented Feb 12, 2025

sdko/sources/fix-source-saving

Closes #12995

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@dominic-r dominic-r requested a review from a team as a code owner February 12, 2025 21:06
@netlify
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit bb3535a
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67ad1f3bdc16aa0008643a56

@netlify
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit bb3535a
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67ad1f3b7752a80008585cf8

@dominic-r dominic-r changed the title sources: fix saving/updating sources: fix saving source in identification stage no longer appears as saved when reopening modal Feb 12, 2025
@dominic-r dominic-r marked this pull request as draft February 12, 2025 21:07
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (ac4d6ae) to head (bb3535a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13005      +/-   ##
==========================================
+ Coverage   92.75%   92.76%   +0.01%     
==========================================
  Files         785      785              
  Lines       39592    39592              
==========================================
+ Hits        36723    36729       +6     
+ Misses       2869     2863       -6     
Flag Coverage Δ
e2e 48.52% <100.00%> (-0.05%) ⬇️
integration 24.54% <0.00%> (ø)
unit 90.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominic-r dominic-r force-pushed the sdko/sources/fix-source-saving branch from c7ab69f to 8cc30e9 Compare February 12, 2025 22:18
@dominic-r dominic-r marked this pull request as ready for review February 12, 2025 22:22
@dominic-r dominic-r requested a review from a team as a code owner February 12, 2025 22:22
Signed-off-by: Dominic R <dominic@sdko.org>
Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12780 is the correct fix for this, changing the lookup_field is not the correct fix and will break a lot of things

@dominic-r dominic-r closed this Feb 13, 2025
@dominic-r dominic-r deleted the sdko/sources/fix-source-saving branch February 13, 2025 00:00
@dominic-r
Copy link
Member Author

dominic-r commented Feb 13, 2025

Yikes... Yea I'll stay in the website/ folder and get out of authentik api land 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Identification Stage Not Saving Source (Using Google Workspace SAML Source)

2 participants