Skip to content

website/integrations: general cleanup and updates#12716

Merged
tanberry merged 23 commits intogoauthentik:mainfrom
dominic-r:sdko/integration-batch-updates/a
Apr 16, 2025
Merged

website/integrations: general cleanup and updates#12716
tanberry merged 23 commits intogoauthentik:mainfrom
dominic-r:sdko/integration-batch-updates/a

Conversation

@dominic-r
Copy link
Copy Markdown
Member

@dominic-r dominic-r commented Jan 17, 2025

sdko/integration-batch-updates/a

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 17, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 1b52e96
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67fe5f30e422a50008b3a361

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 17, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 1b52e96
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67fe5f308b01880008681f98
😎 Deploy Preview https://deploy-preview-12716--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (0606b1a) to head (1b52e96).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12716      +/-   ##
==========================================
+ Coverage   92.72%   92.77%   +0.05%     
==========================================
  Files         798      798              
  Lines       41138    41138              
==========================================
+ Hits        38145    38167      +22     
+ Misses       2993     2971      -22     
Flag Coverage Δ
e2e 47.83% <ø> (+0.07%) ⬆️
integration 24.13% <ø> (ø)
unit 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tanberry tanberry changed the title website/integrations: all: general cleanup and updates website/integrations: all general cleanup and updates Jan 17, 2025
Copy link
Copy Markdown
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @4d62 !

@dominic-r
Copy link
Copy Markdown
Member Author

@tanberry I don't think this is ready for merge yet. I'll finish, if you don't mind, all of the section outlined in notion before merging. Just to not make too many of these

@dominic-r dominic-r force-pushed the sdko/integration-batch-updates/a branch 3 times, most recently from ec33301 to e4217aa Compare January 31, 2025 19:57
Copy link
Copy Markdown
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one request for change; I'm quite serious about not writing your own security code.

@dominic-r dominic-r force-pushed the sdko/integration-batch-updates/a branch from a548660 to c400aba Compare February 12, 2025 23:40
@dominic-r
Copy link
Copy Markdown
Member Author

dominic-r commented Feb 12, 2025

Ken, thanks for the review. Here's an updated version which should fix what was addressed here and on Slack. My dompurify implementation feels botched tho I have absolutely no idea how to make this JSDOM thing work and SSR and whatever else on Netlify. I've passed through the 7 stages of grief with coding

@dominic-r dominic-r force-pushed the sdko/integration-batch-updates/a branch 2 times, most recently from 39eb4d2 to f6b9221 Compare February 13, 2025 16:19
tanberry pushed a commit that referenced this pull request Feb 17, 2025
* update to Wizard and Styling Guide

* Ready for PR

* remove changes on actual budget 

#12716

Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>

---------

Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Co-authored-by: nicedevil007 <nicedevil007@users.noreply.github.com>
@dominic-r dominic-r force-pushed the sdko/integration-batch-updates/a branch 2 times, most recently from 1f16d9e to 9aece2e Compare April 5, 2025 23:26
dominic-r and others added 14 commits April 9, 2025 10:45
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
Co-authored-by: Dewi Roberts <dewi@goauthentik.io>
Signed-off-by: Dominic R <dominic@sdko.org>
@dominic-r
Copy link
Copy Markdown
Member Author

Thanks for correcting my usage of French! @dewi-tik

@dominic-r dominic-r marked this pull request as ready for review April 16, 2025 20:14
@dominic-r dominic-r requested a review from a team as a code owner April 16, 2025 20:14
Copy link
Copy Markdown
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @dominic-r !

@tanberry tanberry merged commit 07f0666 into goauthentik:main Apr 16, 2025
89 checks passed
@dominic-r dominic-r deleted the sdko/integration-batch-updates/a branch April 16, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants