Skip to content

website/integrations: rustdesk-server-pro#12706

Merged
tanberry merged 12 commits intogoauthentik:mainfrom
nicedevil007:rustdesk-pro
Jan 22, 2025
Merged

website/integrations: rustdesk-server-pro#12706
tanberry merged 12 commits intogoauthentik:mainfrom
nicedevil007:rustdesk-pro

Conversation

@nicedevil007
Copy link
Contributor

@tanberry @4d62 it's me again. I hope I did much more right this time from starting. I use the wizard method now to get it up and running as you told me on my last PR.

Now it seems that I don't have anything more up and running that I can connect to authentik :(


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

nicedevil007 and others added 6 commits January 16, 2025 13:21
added rustdesk-pro

Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
@nicedevil007 nicedevil007 requested a review from a team as a code owner January 16, 2025 13:35
@netlify
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 70d0811
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/679111c905e48100087c8e3f
😎 Deploy Preview https://deploy-preview-12706--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 70d0811
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/679111c934cf170008b5005d
😎 Deploy Preview https://deploy-preview-12706--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (91ef8c2) to head (70d0811).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12706      +/-   ##
==========================================
- Coverage   92.77%   92.76%   -0.01%     
==========================================
  Files         769      769              
  Lines       38886    38909      +23     
==========================================
+ Hits        36075    36094      +19     
- Misses       2811     2815       +4     
Flag Coverage Δ
e2e 48.56% <ø> (-0.08%) ⬇️
integration 24.62% <ø> (-0.02%) ⬇️
unit 90.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for yet another contribution. It is greatly appreciated. Here are 3 little things that I noticed. Unfortunately, I'll have to ask Tana about something before continuing to review.

nicedevil007 and others added 3 commits January 16, 2025 15:13
Co-authored-by: 4d62 <git@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Co-authored-by: 4d62 <git@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Co-authored-by: 4d62 <git@sdko.org>
Signed-off-by: NiceDevil <17103076+nicedevil007@users.noreply.github.com>
Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @nicedevil007 and as always, apologies for my slowness! If you ee any other areas where you want to make another contribution (docs or code) we will be happy to see you again; really appreciate your help.

@tanberry tanberry enabled auto-merge (squash) January 22, 2025 15:48
@tanberry tanberry merged commit afe8ab7 into goauthentik:main Jan 22, 2025
@nicedevil007 nicedevil007 deleted the rustdesk-pro branch January 22, 2025 17:24
@nicedevil007
Copy link
Contributor Author

Thank you so much @nicedevil007 and as always, apologies for my slowness! If you ee any other areas where you want to make another contribution (docs or code) we will be happy to see you again; really appreciate your help.

thank you very much, it makes me a bit proud of seeing some of my little work to this project on the mainpage :)

because authentik runs so much more smooth than our IDP we have right now in our company, I'm already planning to switch to authentik when the license runs out.

the only downside authentik for enterprise got right now is the part where it doesn't offer a windows agent to login to a machine. (I know there is a websolution for RDP but I mean a real agent), so maybe in 1-2 years it looks different.

kensternberg-authentik added a commit that referenced this pull request Jan 22, 2025
* main:
  web: update gen-client-ts to OpenAPI 7.11.0 (#12756)
  website/integrations: rustdesk-server-pro (#12706)
  core: bump codespell from 2.3.0 to 2.4.0 (#12762)
  root: docker: ensure apt packages are up-to-date (#12683)
  ci: fix missing build args for dev and release (#12760)
  web: bump vite from 5.4.11 to 5.4.14 in /web (#12757)
  web: bump undici from 6.21.0 to 6.21.1 in /web (#12755)
  lifecycle: fix cryptography's OpenSSL path (#12753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants