Skip to content

website/docs: policy for email whitelist: modernize#12558

Merged
tanberry merged 8 commits intogoauthentik:mainfrom
dominic-r:sdko/website/docs/policies/expression-email-whitelist/upd
Jan 8, 2025
Merged

website/docs: policy for email whitelist: modernize#12558
tanberry merged 8 commits intogoauthentik:mainfrom
dominic-r:sdko/website/docs/policies/expression-email-whitelist/upd

Conversation

@dominic-r
Copy link
Member

sdko/website/docs/policies/expression-email-whitelist/upd

Updates the documentation to add an expression for source authentication. Then, it fixes the existing expression to work with authentik 2024.12.1 . Finally, the documentation page it-self is cleaned up and touched up.

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Updates the documentation to add an expression for source authentication. Then, it fixes the existing expression to work with authentik 2024.12.1 . Finally, the documentation page it-self is cleaned up and touched up.

Signed-off-by: 4d62 <github-user@sdko.org>
Sets the title back to being lowercase, oops

Signed-off-by: 4d62 <github-user@sdko.org>
@dominic-r dominic-r requested a review from a team as a code owner January 4, 2025 02:01
@netlify
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 429eb18
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/677f00a074f62b0008113771

@netlify
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 429eb18
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/677f00a0e97a5b00083ee5ca
😎 Deploy Preview https://deploy-preview-12558--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (1b4fee2) to head (429eb18).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12558      +/-   ##
==========================================
+ Coverage   91.75%   92.70%   +0.95%     
==========================================
  Files         770      769       -1     
  Lines       38873    38823      -50     
==========================================
+ Hits        35667    35990     +323     
+ Misses       3206     2833     -373     
Flag Coverage Δ
e2e 48.50% <ø> (+5.88%) ⬆️
integration 24.65% <ø> (+0.06%) ⬆️
unit 90.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @4d62 !! I added a comment about formatting, and then a question about the word "this".

@dominic-r dominic-r requested a review from tanberry January 7, 2025 01:09
@tanberry
Copy link
Contributor

tanberry commented Jan 8, 2025

When you have a chance, @4d62, you might need to run make website-install on your local repo, to update your Docusaurus version. I see a few suspicious checks in the build are failing. Hopefully running that command will fix it.

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <git@sdko.org>
@dominic-r
Copy link
Member Author

@tanberry ci-website-mark is passing now. Should be good for merge

Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanberry tanberry enabled auto-merge (squash) January 8, 2025 22:58
@tanberry tanberry merged commit f949141 into goauthentik:main Jan 8, 2025
@dominic-r dominic-r deleted the sdko/website/docs/policies/expression-email-whitelist/upd branch January 8, 2025 23:14
kensternberg-authentik added a commit that referenced this pull request Jan 11, 2025
* main:
  website: revise full development environment instructions (#12638)
  website: bump typescript from 5.7.2 to 5.7.3 in /website (#12620)
  website: bump aws-cdk from 2.174.1 to 2.175.0 in /website (#12621)
  ci: bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (#12622)
  core: bump twilio from 9.4.1 to 9.4.2 (#12623)
  core: bump python-kadmin-rs from 0.5.2 to 0.5.3 (#12624)
  core: bump ruff from 0.8.6 to 0.9.0 (#12625)
  core: bump pydantic from 2.10.4 to 2.10.5 (#12626)
  core: bump google-api-python-client from 2.157.0 to 2.158.0 (#12628)
  core: bump goauthentik.io/api/v3 from 3.2024121.3 to 3.2024122.1 (#12629)
  web: bump API Client version (#12617)
  release: 2024.12.2 (#12615)
  website/docs: prepare 2024.12.2 release notes (#12614)
  providers/saml: fix invalid SAML Response when assertion and response are signed (#12611)
  core: fix error when creating new user with default path (#12609)
  rbac: permissions endpoint: allow authenticated users (#12608)
  website/docs: update customer portal (#12603)
  website/docs: policy for email whitelist: modernize (#12558)
mahmoudajawad pushed a commit to mahmoudajawad/authentik that referenced this pull request Jan 15, 2025
* website/docs: policy for email whitelist: revamp

Updates the documentation to add an expression for source authentication. Then, it fixes the existing expression to work with authentik 2024.12.1 . Finally, the documentation page it-self is cleaned up and touched up.

Signed-off-by: 4d62 <github-user@sdko.org>

* website/docs: policy for email whitelist: lowercase title

Sets the title back to being lowercase, oops

Signed-off-by: 4d62 <github-user@sdko.org>

* website/docs: customize: whatever-title-i-put-before: lint

Lints the code with prettier.

* remind me to not run npx prettier --write website/docs/

* suggestions

* Update website/docs/customize/policies/expression/whitelist_email.md

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <git@sdko.org>

* Update website/docs/customize/policies/expression/whitelist_email.md

Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>

---------

Signed-off-by: 4d62 <github-user@sdko.org>
Signed-off-by: 4d62 <git@sdko.org>
Signed-off-by: Tana M Berry <tanamarieberry@yahoo.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants