website/integrations: portainer: group config steps#12548
website/integrations: portainer: group config steps#12548tanberry merged 1 commit intogoauthentik:mainfrom
Conversation
Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dominic-r
left a comment
There was a problem hiding this comment.
Thank you for your contribution; it is greatly appreciated. We are currently updating the integration documentation to use the wizard for configuration instead of the manual approach. Could you update the “authentik configuration” section to reflect this change? Please let me know if you have any questions.
tanberry
left a comment
There was a problem hiding this comment.
Whoa, that was indeed messy before you cleaned it up! Thanks so much, @CFenner for this PR. Much better to have the two sections of authentik config and service config clearly separated.
Eventually we want to change all of the Integration guides to use the Wizard process for creating apps and providers. Myself and @4d62 are working on a standardized block of text for the "authentik configuration" section, which we will add to the template as well.
But for now, this is a huge improvement, thank you.
Oh haha, I hadn't seen this. Yes, sorry I repeated what @4d62 said about updating the section about creating the provider and app to use the Wizard. Feel free to do it now in this PR, or you can open a new PR later to do so. As you wish. |
|
I would prefer to keep it as is now, if this is fine, as I have no idea about the wizard and a lack of time diving into that for now, sorry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12548 +/- ##
==========================================
+ Coverage 92.69% 92.75% +0.05%
==========================================
Files 770 770
Lines 38873 38873
==========================================
+ Hits 36033 36056 +23
+ Misses 2840 2817 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Seems good with me. Thanks again for helping out. |
* main: lib: add expression helper ak_create_jwt to create JWTs (#12599) api: cleanup owner permissions (#12598) website: bump aws-cdk from 2.174.0 to 2.174.1 in /website (#12593) core: bump aws-cdk-lib from 2.174.0 to 2.174.1 (#12594) website/integrations: portainer: group config steps (#12548) translate: Updates for file web/xliff/en.xlf in fi (#12586) translate: Updates for file locale/en/LC_MESSAGES/django.po in fi (#12584) website/docs: fix Nginx redirection example (#12561)
Update index.md Signed-off-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com>
Details
Group the config steps in
authentik configurationand<application> configurationas seen for other applications.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)