Skip to content

website/integrations: Update Frappe Application index.md#12527

Merged
tanberry merged 1 commit intogoauthentik:mainfrom
aquiveal:patch-1
Jan 3, 2025
Merged

website/integrations: Update Frappe Application index.md#12527
tanberry merged 1 commit intogoauthentik:mainfrom
aquiveal:patch-1

Conversation

@aquiveal
Copy link
Contributor

@aquiveal aquiveal commented Jan 1, 2025

Details

REPLACE ME

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@aquiveal
Update index.md
db012e4 
Signed-off-by: Aryan Singh <34374286+aquiveal@users.noreply.github.com>
@aquiveal aquiveal requested a review from a team as a code owner January 1, 2025 09:35
@netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit db012e4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67750c6be95d5b00081c568a

@netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit db012e4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67750c6bc567130008ff7a93
😎 Deploy Preview https://deploy-preview-12527--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dominic-r
Copy link
Member

dominic-r commented Jan 1, 2025

From what I can see, Frappe has several products and the helpdesk is a real thing

@aquiveal
Copy link
Contributor Author

aquiveal commented Jan 1, 2025

From what I can see, Frappe has several products and the helpdesk is a real thing

Yes, Frappe does, and this guide works for all apps built using the Frappe framework. I successfully used this guide with ERPNext and HRMS, but it was difficult to find because it was listed as "helpdesk." I might have overlooked it otherwise. However, I had to adjust the redirect URL because the guide's instructions, if followed precisely, produced a mismatched redirect URL error.

@dominic-r
Copy link
Member

dominic-r commented Jan 1, 2025

Ah got it, that makes more sense. Thanks for clarifying. Should have read the note on line 11. Changes look good overall. Thanks for your contribution

dominic-r
dominic-r approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanberry tanberry changed the title Update Frappe Application index.md website/integrations: Update Frappe Application index.md Jan 3, 2025
tanberry
tanberry approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aquiveal for updating this integration guide!

@codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (5ebd280) to head (db012e4).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12527   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         770      770           
  Lines       38873    38873           
=======================================
+ Hits        36059    36062    +3     
+ Misses       2814     2811    -3
Flag Coverage Δ
e2e 48.76% <ø> (+0.05%) ⬆️
integration 24.58% <ø> (ø)
unit 90.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry tanberry merged commit 23faa0b into goauthentik:main Jan 3, 2025
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
@kensternberg-authentik
Merge branch 'main' into dev
854427e 
* main:
  core: bump golang.org/x/oauth2 from 0.24.0 to 0.25.0 (#12571)
  website: bump the docusaurus group in /website with 9 updates (#12569)
  core: bump github.com/coreos/go-oidc/v3 from 3.11.0 to 3.12.0 (#12572)
  core: bump ruff from 0.8.5 to 0.8.6 (#12573)
  ci: release: fix AWS cfn template permissions (#12576)
  translate: Updates for file web/xliff/en.xlf in fr (#12578)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#12577)
  sources/kerberos: authenticate with the user's username instead of the first username in authentik (#12497)
  website/integrations: Fix deprecated terraform ressource authentik_scope_mapping in docs (#12554)
  website/user-sources Fix Free IPA docs page (#12549)
  core: bump aws-cdk-lib from 2.173.4 to 2.174.0 (#12574)
  website/integrations: semaphore: fix formatting (#12567)
  website: bump aws-cdk from 2.173.4 to 2.174.0 in /website (#12570)
  website/integrations: Update Frappe Application index.md (#12527)
  website: add api reference docs to redirect file (#12551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanberry tanberry tanberry approved these changes

@dominic-r dominic-r dominic-r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aquiveal @dominic-r @tanberry