providers/saml: fix handle Accept: application/xml for SAML Metadata endpoint (#12483)#12518
Merged
BeryJu merged 2 commits intogoauthentik:mainfrom Dec 30, 2024
Merged
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12518 +/- ##
==========================================
- Coverage 92.76% 92.75% -0.01%
==========================================
Files 770 770
Lines 38859 38873 +14
==========================================
+ Hits 36047 36057 +10
- Misses 2812 2816 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
approved these changes
Dec 30, 2024
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 8, 2025
* main: website/integrations: meshcentral: document (#12509) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#12524) core: bump goauthentik.io/api/v3 from 3.2024121.2 to 3.2024121.3 (#12522) web: bump API Client version (#12520) website/integrations: chronograf: document (#12474) website/integrations: update preparation placeholder (#12507) providers/saml: fix handle Accept: application/xml for SAML Metadata endpoint (#12483) (#12518) core: bump aws-cdk-lib from 2.173.3 to 2.173.4 (#12513) website: bump aws-cdk from 2.173.3 to 2.173.4 in /website (#12514) core: bump coverage from 7.6.9 to 7.6.10 (#12499) core: bump aws-cdk-lib from 2.173.2 to 2.173.3 (#12500) website: bump aws-cdk from 2.173.2 to 2.173.3 in /website (#12501) core: bump github.com/go-ldap/ldap/v3 from 3.4.9 to 3.4.10 (#12502) website/docs: New "Whats Up Docker" URL (#12488)
|
Has this been released in 2024.12.2? Still facing the same issue. |
Contributor
|
Not working 2024.12.3 either 😢 |
Contributor
Author
|
@jorhett @franciscomfcmaia This has been included in 2025.02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Currently when requesting SAML metadata download with
Accept: application/xmlit returns a status406 Not Acceptable.Expected behavior would be to return the data as is done when no Accept header is sent.
This adds a new renderer_class to the SAML metadata download endpoint which allows application/xml in the Accept header.
Now both
curl "http://localhost:9000/api/v3/providers/saml/1/metadata/?download"and
curl -H "Accept: application/xml" "http://localhost:9000/api/v3/providers/saml/1/metadata/?download"produce the same output, instead of the latter returning 406.
closes #12483
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
The code has been formatted (No frontend changes mademake web)If applicable
The documentation has been updatedThe documentation has been formatted (make website)