Skip to content

internal: fix missing trailing slash in outpost websocket#12470

Merged
BeryJu merged 1 commit intomainfrom
internal/fix-outpost-missing-slash
Dec 23, 2024
Merged

internal: fix missing trailing slash in outpost websocket#12470
BeryJu merged 1 commit intomainfrom
internal/fix-outpost-missing-slash

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 23, 2024

Details

closes #12464


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner December 23, 2024 21:23
@BeryJu
Copy link
Member Author

BeryJu commented Dec 23, 2024

/cherry-pick version-2024.12

@netlify
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 0a86c50
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6769d4c1c0f1000008672240

@netlify
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0a86c50
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6769d4c1b72e07000898df92

@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (aa4f817) to head (0a86c50).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12470   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         770      770           
  Lines       38859    38859           
=======================================
+ Hits        36047    36048    +1     
+ Misses       2812     2811    -1     
Flag Coverage Δ
e2e 48.76% <ø> (+0.04%) ⬆️
integration 24.59% <ø> (ø)
unit 90.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0a86c50d12ee03a6b5fa25f9b2d9602c1af67ed7
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-0a86c50d12ee03a6b5fa25f9b2d9602c1af67ed7-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-0a86c50d12ee03a6b5fa25f9b2d9602c1af67ed7

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-0a86c50d12ee03a6b5fa25f9b2d9602c1af67ed7-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit ee6fcdf into main Dec 23, 2024
@BeryJu BeryJu deleted the internal/fix-outpost-missing-slash branch December 23, 2024 22:42
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 23, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Dec 23, 2024
…#12470) (#12471)

internal: fix missing trailing slash in outpost websocket (#12470)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
* main: (118 commits)
  outposts: fix version label (#12486)
  web: only load version context when authenticated (#12482)
  core: bump goauthentik.io/api/v3 from 3.2024120.2 to 3.2024121.2 (#12478)
  ci: bump helm/kind-action from 1.11.0 to 1.12.0 (#12479)
  web: fix build dev build (#12473)
  root: fix dev build version being invalid semver (#12472)
  internal: fix missing trailing slash in outpost websocket (#12470)
  web: bump API Client version (#12469)
  admin: monitor worker version (#12463)
  core: bump jinja2 from 3.1.4 to 3.1.5 (#12467)
  web: bump API Client version (#12468)
  release: 2024.12.1 (#12466)
  web: misc fixes for admin and flow inspector (#12461)
  website/docs: 2024.12.1 release notes (#12462)
  core: bump goauthentik.io/api/v3 from 3.2024120.1 to 3.2024120.2 (#12456)
  core: bump urllib3 from 2.2.3 to 2.3.0 (#12457)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12454)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12453)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12455)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12458)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2024.12.1 seems to break outpost websocket completly

1 participant