core: applications api: properly select provider by rissson · Pull Request #10373 · goauthentik/authentik

rissson · 2024-07-04T13:10:49Z

Details

REPLACE ME

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

netlify · 2024-07-04T13:11:06Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`d823ff7`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/66b0d86fb70c2b000835c747
😎 Deploy Preview	https://deploy-preview-10373--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-07-04T13:11:07Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`d823ff7`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/66b0d86fff387600088a238c
😎 Deploy Preview	https://deploy-preview-10373--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

…unch url (#10336)" (#10370) This reverts commit 763a19b.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

authentik/core/models.py

codecov · 2024-07-04T13:22:59Z

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (446a65d) to head (d823ff7).

Files	Patch %	Lines
authentik/providers/saml/views/metadata.py	25.00%	3 Missing ⚠️
authentik/core/api/applications.py	80.00%	2 Missing ⚠️
authentik/core/models.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10373      +/-   ##
==========================================
- Coverage   92.63%   92.53%   -0.11%     
==========================================
  Files         721      721              
  Lines       35354    35379      +25     
==========================================
- Hits        32750    32737      -13     
- Misses       2604     2642      +38

Flag	Coverage Δ
e2e	`49.63% <81.25%> (-0.12%)`	⬇️
integration	`25.36% <37.50%> (+0.01%)`	⬆️
unit	`90.03% <68.75%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-04T13:34:50Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d823ff76ba09d839aa69423d51da6fe7365745d5
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d823ff76ba09d839aa69423d51da6fe7365745d5-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d823ff76ba09d839aa69423d51da6fe7365745d5

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d823ff76ba09d839aa69423d51da6fe7365745d5-arm64

Afterwards, run the upgrade commands from the latest release notes.

authentik/core/api/applications.py

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

* refs/remotes/origin/main: (37 commits) release: 2024.6.3 website/docs: prepare 2024.6.3 release notes (#10775) website/scripts: updated readme, added docsmg.env file (#10710) web: bump API Client version (#10777) root: fix opencontainers ref (#10776) core: applications api: properly select provider (#10373) root: remove warnings (#10774) enterprise/rac: fix error when listing connection tokens as non-superuser (#10771) core: bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 (#10754) core: bump goauthentik.io/api/v3 from 3.2024062.1 to 3.2024062.2 (#10753) core: bump golang.org/x/sync from 0.7.0 to 0.8.0 (#10755) web: bump the rollup group across 1 directory with 3 updates (#10756) web: bump core-js from 3.37.1 to 3.38.0 in /web (#10757) web: bump @swc/core from 1.7.4 to 1.7.6 in /web/sfe (#10758) web: bump rollup from 4.19.2 to 4.20.0 in /web/sfe (#10759) core: bump black from 24.4.2 to 24.8.0 (#10760) core: bump msgraph-sdk from 1.5.3 to 1.5.4 (#10761) core: bump coverage from 7.6.0 to 7.6.1 (#10762) core: bump ruff from 0.5.5 to 0.5.6 (#10763) core: bump django-filter from 24.2 to 24.3 (#10764) ...

* main: (37 commits) release: 2024.6.3 website/docs: prepare 2024.6.3 release notes (#10775) website/scripts: updated readme, added docsmg.env file (#10710) web: bump API Client version (#10777) root: fix opencontainers ref (#10776) core: applications api: properly select provider (#10373) root: remove warnings (#10774) enterprise/rac: fix error when listing connection tokens as non-superuser (#10771) core: bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 (#10754) core: bump goauthentik.io/api/v3 from 3.2024062.1 to 3.2024062.2 (#10753) core: bump golang.org/x/sync from 0.7.0 to 0.8.0 (#10755) web: bump the rollup group across 1 directory with 3 updates (#10756) web: bump core-js from 3.37.1 to 3.38.0 in /web (#10757) web: bump @swc/core from 1.7.4 to 1.7.6 in /web/sfe (#10758) web: bump rollup from 4.19.2 to 4.20.0 in /web/sfe (#10759) core: bump black from 24.4.2 to 24.8.0 (#10760) core: bump msgraph-sdk from 1.5.3 to 1.5.4 (#10761) core: bump coverage from 7.6.0 to 7.6.1 (#10762) core: bump ruff from 0.5.5 to 0.5.6 (#10763) core: bump django-filter from 24.2 to 24.3 (#10764) ...

core: applications api: properly select provider

621e964

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

rissson self-assigned this Jul 4, 2024

rissson requested a review from a team as a code owner July 4, 2024 13:10

rissson added 4 commits July 4, 2024 15:12

fixup get_launch_url

6d684ce

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

wip

303a024

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

Reapply "core: applications api: add option to only list apps with la…

c29fad6

…unch url (#10336)" (#10370) This reverts commit 763a19b.

wip

c8ed1b6

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

rissson requested review from a team as code owners July 4, 2024 13:13

rissson added 2 commits July 4, 2024 15:15

more fixes

fe5b54a

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

make website

fd2c84d

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

rissson commented Jul 4, 2024

View reviewed changes

authentik/core/models.py Show resolved Hide resolved

BeryJu reviewed Jul 22, 2024

View reviewed changes

authentik/core/api/applications.py Show resolved Hide resolved

Merge branch 'main' into application-remove-get-provider

f31a68c

rissson requested a review from BeryJu August 5, 2024 11:01

rissson added 2 commits August 5, 2024 15:49

remove serializer change

62e6bd0

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>

Merge branch 'main' into application-remove-get-provider

d823ff7

BeryJu merged commit b942ae7 into main Aug 5, 2024

BeryJu deleted the application-remove-get-provider branch August 5, 2024 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

core: applications api: properly select provider#10373

core: applications api: properly select provider#10373
BeryJu merged 10 commits intomainfrom
application-remove-get-provider

rissson commented Jul 4, 2024

Uh oh!

netlify bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rissson commented Jul 4, 2024

Details

Checklist

Uh oh!

netlify bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs ready!

Uh oh!

netlify bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

Uh oh!

codecov bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading

codecov bot commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading