Skip to content

providers/saml: fix metadata import error handling#10349

Merged
rissson merged 1 commit intomainfrom
providers/saml/fix-metadata-import-error
Jul 3, 2024
Merged

providers/saml: fix metadata import error handling#10349
rissson merged 1 commit intomainfrom
providers/saml/fix-metadata-import-error

Conversation

@BeryJu
Copy link
Copy Markdown
Member

@BeryJu BeryJu commented Jul 3, 2024

Details

closes #10141


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 3, 2024 15:20
@BeryJu
Copy link
Copy Markdown
Member Author

BeryJu commented Jul 3, 2024

/cherry-pick version-2024.6

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 3, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit fcf08fb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66856c354c6db40008d7750b

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 3, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit fcf08fb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66856c357e23170008334c46

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (fc39323) to head (fcf08fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10349   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         713      713           
  Lines       34978    34978           
=======================================
  Hits        32407    32407           
  Misses       2571     2571           
Flag Coverage Δ
e2e 49.55% <ø> (ø)
integration 25.38% <ø> (ø)
unit 90.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-fcf08fb6899fdd8a06bba78b947d57ca8ec36563
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-fcf08fb6899fdd8a06bba78b947d57ca8ec36563-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-fcf08fb6899fdd8a06bba78b947d57ca8ec36563

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-fcf08fb6899fdd8a06bba78b947d57ca8ec36563-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit 7b64620 into main Jul 3, 2024
@rissson rissson deleted the providers/saml/fix-metadata-import-error branch July 3, 2024 15:45
rissson pushed a commit that referenced this pull request Jul 3, 2024
… (#10350)

Co-authored-by: Jens L <jens@goauthentik.io>
fix metadata import error handling (#10349)
kensternberg-authentik added a commit that referenced this pull request Jul 5, 2024
* main:
  website/docs: add links and tweaks to existing docs on flow executors (#10340)
  sources/saml: fix pickle error, add saml auth tests (#10348)
  web: bump API Client version (#10351)
  core: applications api: add option to only list apps with launch url (#10336)
  website/integrations: minio: configure openid on web (#9874)
  website/docs: integrations: gitea: specify callback url (#10180)
  providers/saml: fix metadata import error handling (#10349)
  core, web: update translations (#10341)
  core: bump twilio from 9.2.2 to 9.2.3 (#10343)
  core: bump google-api-python-client from 2.135.0 to 2.136.0 (#10344)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#10339)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#10338)
  web: bump the storybook group in /web with 7 updates (#10263)
  web: lintpicking (#10212)
kensternberg-authentik added a commit that referenced this pull request Jul 15, 2024
* main:
  website/docs: add links and tweaks to existing docs on flow executors (#10340)
  sources/saml: fix pickle error, add saml auth tests (#10348)
  web: bump API Client version (#10351)
  core: applications api: add option to only list apps with launch url (#10336)
  website/integrations: minio: configure openid on web (#9874)
  website/docs: integrations: gitea: specify callback url (#10180)
  providers/saml: fix metadata import error handling (#10349)
  core, web: update translations (#10341)
  core: bump twilio from 9.2.2 to 9.2.3 (#10343)
  core: bump google-api-python-client from 2.135.0 to 2.136.0 (#10344)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#10339)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#10338)
  web: bump the storybook group in /web with 7 updates (#10263)
  web: lintpicking (#10212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAML: Failed to verify Metadata Signature results in Python KeyError results in 405 Metthod not allowed

2 participants