website/docs: Fix nginx proxy_pass directive documentation#10181
Merged
rissson merged 2 commits intogoauthentik:mainfrom Jun 20, 2024
Merged
website/docs: Fix nginx proxy_pass directive documentation#10181rissson merged 2 commits intogoauthentik:mainfrom
rissson merged 2 commits intogoauthentik:mainfrom
Conversation
Signed-off-by: Mike Fotinakis <mike@fotinakis.com>
Signed-off-by: Mike Fotinakis <mike@fotinakis.com>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
BeryJu
approved these changes
Jun 20, 2024
Member
BeryJu
left a comment
There was a problem hiding this comment.
I don't even remember where this incorrect configuration came from tbh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10181 +/- ##
==========================================
- Coverage 92.62% 92.61% -0.01%
==========================================
Files 712 712
Lines 34933 34933
==========================================
- Hits 32356 32354 -2
- Misses 2577 2579 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Thanks @BeryJu 👍 FYI: this only worked for me using a manual outpost. I'm unable to get any kind of |
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 24, 2024
* main: website/docs: Fix nginx proxy_pass directive documentation (#10181) website/docs: Remove hyphen in read replica in Release Notes (#10178) core: rework base for SkipObject exception to better support control flow exceptions (#10186) web: bump glob from 10.4.1 to 10.4.2 in /web (#10163) core: bump google-api-python-client from 2.133.0 to 2.134.0 (#10183) web: bump @sentry/browser from 8.9.2 to 8.10.0 in /web in the sentry group (#10185) website/docs: update template reference (#10166)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
As per the nginx docs,
proxy_passsets the baseline for the reverse proxied URLs and will prepend theproxy_passURL.In the nginx docs in authentik, it's currently misdocumented and causes a duplicate
/outpost.goauthentik.iopath to be added during the rewrite, causing 404s with the forward auth (single domain) proxy setup and likely others?I believe this might be the cause of a few github issues noticing 404s on the outpost, namely things like #9122 and maybe others.
Previous behavior (incorrect):
https://some-proxy.company/outpost.goauthentik.io/auth/nginxhttp://outpost.company:9000/outpost.goauthentik.io/outpost.goauthentik.io/auth/nginx(incorrect)New behavior:
https://some-proxy.company/outpost.goauthentik.io/auth/nginxhttp://outpost.company:9000/outpost.goauthentik.io/auth/nginx