This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Upgrade to go v1.13#510
Closed
chenrui333 wants to merge 2 commits intogo-yaml:v2from
chenrui333:go-1.13
Closed
Conversation
|
Why? |
Contributor
Author
|
@dolmen, why not? |
Contributor
|
We want to make sure it continues to work in prior versions. Adding to the list is fine, though. |
Contributor
|
We should probably also compile with |
Contributor
Author
|
That makes sense, I will add more golang versions for testing. |
Contributor
Author
|
@niemeyer I think it should be good now! |
laverya
added a commit
to laverya/yaml
that referenced
this pull request
Oct 17, 2019
also test on both osx and linux copies go-yaml#510, but for the v3 branch
niemeyer
suggested changes
Oct 18, 2019
Contributor
|
I went ahead and did the change simply adding the missing versions on 1ed5951. |
Contributor
Author
|
Thanks @niemeyer. Also, I just create a new PR for cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.