-
-
Notifications
You must be signed in to change notification settings - Fork 779
feat: add native core utils to improve compatibility on windows #2360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Go 1.25.0 is out now. 🚀 |
16720a5 to
abf1aca
Compare
|
This is now ready to Go. I made the env shorter, just I wrote a blog post which can be previewed on this link. |
|
Super excited about this being merged and released, thank you so much @andreynering!!! 😄 |
abf1aca to
5c144db
Compare
pd93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! So good to finally see this land 🚀
vmaerten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally 🚀
I’ve left some questions.
TODO:
TASK_CORE_UTILSenv settingThis PR makes Task start using some core utils from the u-root project so we can have a much improved compability on Windows.
Although it should work most of the time, it's important to know that there might be small implementation differences between GNU or macOS core utils and these Go-implemented ones. Because of this, I decided to only enable it by default on Windows for now, but you can still control that:
TASK_CORE_UTILSis set to either0(disabled) or1(enabled), this will be respected no matter the operating system.Available core utils More can be added with time):