statement: Fix conversion of Valuer#710
Merged
julienschmidt merged 5 commits intogo-sql-driver:masterfrom Nov 17, 2017
linxGnu:master
Merged
statement: Fix conversion of Valuer#710julienschmidt merged 5 commits intogo-sql-driver:masterfrom linxGnu:master
julienschmidt merged 5 commits intogo-sql-driver:masterfrom
linxGnu:master
Conversation
Valuer has the right to return error instead of driver.ErrSkip
Valuer has the right to return error instead of returning driver.ErrSkip as current
This reverts commit 627775d.
julienschmidt
approved these changes
Nov 17, 2017
5 tasks
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this pull request
Mar 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current fix is returning
driver.ErrSkipwhen converter failed to convert valuer.It should be right to give error validation to valuer instead of skipping like this. In this update, I also give a check to valuer interface and call for it to convert, fix error #708 #706
Checklist