stmt: add json.RawMessage for converter and prepared statement#1059
Merged
methane merged 1 commit intogo-sql-driver:masterfrom Feb 18, 2020
Merged
stmt: add json.RawMessage for converter and prepared statement#1059methane merged 1 commit intogo-sql-driver:masterfrom
methane merged 1 commit intogo-sql-driver:masterfrom
Conversation
methane
reviewed
Feb 14, 2020
methane
reviewed
Feb 14, 2020
methane
approved these changes
Feb 14, 2020
Contributor
Author
|
Hey guys, |
Following go-sql-driver#1058, in order for the driver.Value to get as a json.RawMessage, the converter should accept it as a valid value, and handle it as bytes in case where interpolation is disabled
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
…l-driver#1059) Following go-sql-driver#1058, in order for the driver.Value to get as a json.RawMessage, the converter should accept it as a valid value, and handle it as bytes in case where interpolation is disabled
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
…l-driver#1059) Following go-sql-driver#1058, in order for the driver.Value to get as a json.RawMessage, the converter should accept it as a valid value, and handle it as bytes in case where interpolation is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1058, in order for the
driver.Valueto get as ajson.RawMessage, the converter should accept it as a valid value, and handle it as bytes in case where interpolation is disabledDescription
Please explain the changes you made here.
Checklist
cc @alexsn