fix(expand): parameters & responses should properly follow remote doc resolution when SKipSchema#183
Merged
fredbi merged 2 commits intogo-openapi:masterfrom Jan 9, 2024
Merged
Conversation
Member
fredbi
commented
Jan 8, 2024
- fixes Expander: when expanding with SkipSchema, the relative path is lost #182
- contributes Flatten stopped processing nested directories in v0.26.0 go-swagger/go-swagger#2743
… resolution when SKipSchema * fixes go-openapi#182 * contributes go-swagger/go-swagger#2743 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 64.78% 65.43% +0.65%
==========================================
Files 29 29
Lines 2845 2844 -1
==========================================
+ Hits 1843 1861 +18
+ Misses 833 820 -13
+ Partials 169 163 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Member
Author
|
Added PRs with additional testing in known repos using this feature:
Seems to work, even if tinkering with this part has always been a bit dodgy... |
youyuanwu
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.