test(flatten): asserts that the ExpandSpec fix in spec works#93
Merged
fredbi merged 1 commit intogo-openapi:masterfrom Jan 9, 2024
Merged
test(flatten): asserts that the ExpandSpec fix in spec works#93fredbi merged 1 commit intogo-openapi:masterfrom
fredbi merged 1 commit intogo-openapi:masterfrom
Conversation
This reproduces the $ref issue with relative paths in sibling folders in responses (same applies to parameters, but not schemas). Added a test to verify that: * (i) the invalid path that used to work no longer does * (ii) the valid path that used not to work now does * contributes go-swagger/go-swagger#2743 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
6d91d00 to
a12c0ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 15 15
Lines 2566 2566
=======================================
Hits 2354 2354
Misses 158 158
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
This a test-only follow-up on go-openapi/spec#183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reproduces the $ref issue with relative paths in sibling folders in responses (same applies to parameters, but not schemas).
Added a test to verify that:
(i) the invalid path that used to work no longer does
(ii) the valid path that used not to work now does
contributes Flatten stopped processing nested directories in v0.26.0 go-swagger/go-swagger#2743