fix APIError to always report errors#243
Merged
casualjim merged 1 commit intogo-openapi:masterfrom May 5, 2022
eluv-io:fix-api-errors
Merged
fix APIError to always report errors#243casualjim merged 1 commit intogo-openapi:masterfrom eluv-io:fix-api-errors
casualjim merged 1 commit intogo-openapi:masterfrom
eluv-io:fix-api-errors
Conversation
* add unit-test Signed-off-by: elv-gilles <gilles.gaillard@eluv.io>
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 79.94% 80.16% +0.21%
==========================================
Files 42 42
Lines 3181 3186 +5
==========================================
+ Hits 2543 2554 +11
+ Misses 526 519 -7
- Partials 112 113 +1
Continue to review full report at Codecov.
|
casualjim
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command
swagger generate clientis generating client code looking like this:With errors that do not implement json marshalling the original error is wipped of the output:
After applying the patch: