Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-openapi/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.0
Choose a base ref
...
head repository: go-openapi/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.26.2
Choose a head ref
  • 11 commits
  • 78 files changed
  • 4 contributors

Commits on Dec 7, 2023

  1. chore: relint & update

    * updated go version requirement to go1.19
    * updated dependencies, excepted:
       * yaml (upgrade to v3 deferred to another PR)
       * otel (upgrade is breaking: deferred to another PR)
    
    * ci: updated linting rules, in line with other go-openapi repos
       * exception: disabled the "nilerr" linter, which currently crashes for
         this repo
    * ci:updated github actions, in line with other go-openapi repos
    * doc: updated README links and badges
    
    * major relinting of all test code
    * relinting non-test code is deferred to another PR (hopefully with less changes)
    * changes to non-test code are limited to:
      * addition of (temporary) nolint directives
      * gofmt/typos in comments
      * unused params
    
    TODO in forthcoming PRs:
    * [ ] upgrade to yaml/v3
    * [ ] upgrade OTEL packages
    * [ ] gradually remove most "nolint" directives in non-test code
    * [ ] complete test refactoring: some nolint directives have been added
          to skip more complex refacoring (e.g. duplicate code)
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e4cc157 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge pull request #269 from fredbi/chore/update-linting

    chore: relint & update
    casualjim authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    381952b View commit details
    Browse the repository at this point in the history
  2. upgraded opentelemetry client to OTEL v1.17.0

    * NOTE: otel v1.17.0 is the last version supporting go1.19.
      more recent otel packages (now v1.21.0) require go1.20.
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1d20135 View commit details
    Browse the repository at this point in the history
  3. upgraded to yaml.v3

    * fixes #245
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    337c930 View commit details
    Browse the repository at this point in the history
  4. added check to prevent HasContent() to panic after the reader is

    closed
    
    * fixes #268
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1af6e90 View commit details
    Browse the repository at this point in the history
  5. chore: relinting, continued

    This phase applies trivial relinting fixes, to keep the amount of
    changes reviewable.
    
    Non-trivial fixes are deferred to a follow-up PR.
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    42df208 View commit details
    Browse the repository at this point in the history
  6. test: refactored tests for authenticators

    * addressed code duplication in tests
    * used sub tests to improve readability
    * covered a few additional edged cases (passing unexpected types, empty
      realm)
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4bad8c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge pull request #274 from fredbi/chore/linting-phase2

    chore: relinting, continued
    youyuanwu authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    8e5f477 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #275 from fredbi/chore/linting-phase3

    test: refact tests for authenticators
    youyuanwu authored Dec 9, 2023
    Configuration menu
    Copy the full SHA
    7c81d43 View commit details
    Browse the repository at this point in the history
  3. handle EOF when detect content type

    stingshen authored and casualjim committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    5adaa35 View commit details
    Browse the repository at this point in the history
  4. fix linting warnings

    casualjim committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    7c6b268 View commit details
    Browse the repository at this point in the history
Loading